Skip to content

Commit

Permalink
test(duckdb): add test for supporting fixed-size array types (#9855)
Browse files Browse the repository at this point in the history
These are already supported automatically through sqlglot, just adding a
test here. Fixes #7963.

One open question: currently these are cast to variable-length lists in
`to_pyarrow` (matching the existing behavior of `dt.Array` types), but
it could be argued that we should pass them through as fixed-length
lists instead. This would require a bit of work, but nothing too tricky.
  • Loading branch information
jcrist authored Aug 16, 2024
1 parent 93db1b8 commit 98af798
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ibis/backends/duckdb/tests/test_datatypes.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
("UUID", dt.uuid),
("VARCHAR", dt.string),
("INTEGER[]", dt.Array(dt.int32)),
("INTEGER[3]", dt.Array(dt.int32)),
("MAP(VARCHAR, BIGINT)", dt.Map(dt.string, dt.int64)),
(
"STRUCT(a INTEGER, b VARCHAR, c MAP(VARCHAR, DOUBLE[])[])",
Expand Down

0 comments on commit 98af798

Please sign in to comment.