-
Notifications
You must be signed in to change notification settings - Fork 598
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
perf(duckdb): reduce branching factor for ArrayDistinct
If I do something like `some_really_complex_array_expression.unique()`, then the SQL for `some_really_complex_array_expression` was duplicated 4 times. Now it is only duplicated 3 times. This is important for perf, because duckdb sometimes appears to not be smart, and actually does a computation for each time a subexpression appears. See duckdb/duckdb#14649. So this can reduce the computation time to 3/4 of what it was. I want to go through our other compilation steps and do similar optimizations whenever possible.
- Loading branch information
Showing
2 changed files
with
10 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters