feat(clickhouse): implement ops.StringAscii

ibis-project · Feb 5, 2023 · a507d17 · a507d17
1 parent 8bf203c
commit a507d17
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/ibis/backends/clickhouse/compiler/values.py b/ibis/backends/clickhouse/compiler/values.py
@@ -1029,6 +1029,7 @@ def formatter(op, **kw):
     ops.Strip: "trimBoth",
     ops.RegexSearch: "match",
     ops.RegexReplace: "replaceRegexpAll",
+    ops.StringAscii: "ascii",
     # Temporal operations
     ops.Date: "toDate",
     ops.TimestampNow: "now",

diff --git a/ibis/backends/tests/test_string.py b/ibis/backends/tests/test_string.py
@@ -208,7 +208,7 @@ def test_string_col_is_unicode(alltypes, df):
             lambda t: t.string_col.ascii_str(),
             lambda t: t.string_col.map(ord).astype('int32'),
             id='ascii_str',
-            marks=pytest.mark.notimpl(["clickhouse", "datafusion", "polars"]),
+            marks=pytest.mark.notimpl(["datafusion", "polars"]),
         ),
         param(
             lambda t: t.string_col.length(),