fix(datafusion/exasol/mssql/orace): make concat with null value consi…

…stent
ibis-project · Feb 11, 2024 · a51468d · a51468d
1 parent 5121474
commit a51468d
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 0 deletions.
diff --git a/ibis/backends/datafusion/compiler.py b/ibis/backends/datafusion/compiler.py
@@ -420,6 +420,11 @@ def visit_IsInf(self, op, *, arg):
     def visit_ArrayIndex(self, op, *, arg, index):
         return self.f.array_element(arg, index + self.cast(index >= 0, op.index.dtype))
 
+    @visit_node.register(ops.StringConcat)
+    def visit_StringConcat(self, op, *, arg):
+        any_args_null = (a.is_(NULL) for a in arg)
+        return self.if_(sg.or_(*any_args_null), NULL, self.f.concat(*arg))
+
     @visit_node.register(ops.Arbitrary)
     @visit_node.register(ops.ArgMax)
     @visit_node.register(ops.ArgMin)

diff --git a/ibis/backends/exasol/compiler.py b/ibis/backends/exasol/compiler.py
@@ -2,6 +2,7 @@
 
 from functools import singledispatchmethod
 
+import sqlglot as sg
 import sqlglot.expressions as sge
 
 import ibis.common.exceptions as com
@@ -101,6 +102,11 @@ def visit_StringContains(self, op, *, haystack, needle):
     def visit_ExtractSecond(self, op, *, arg):
         return self.f.floor(self.cast(self.f.extract(self.v.second, arg), op.dtype))
 
+    @visit_node.register(ops.StringConcat)
+    def visit_StringConcat(self, op, *, arg):
+        any_args_null = (a.is_(NULL) for a in arg)
+        return self.if_(sg.or_(*any_args_null), NULL, self.f.concat(*arg))
+
     @visit_node.register(ops.AnalyticVectorizedUDF)
     @visit_node.register(ops.ApproxMedian)
     @visit_node.register(ops.Arbitrary)

diff --git a/ibis/backends/mssql/compiler.py b/ibis/backends/mssql/compiler.py
@@ -390,6 +390,11 @@ def visit_HexDigest(self, op, *, arg, how):
             )
         )
 
+    @visit_node.register(ops.StringConcat)
+    def visit_StringConcat(self, op, *, arg):
+        any_args_null = (a.is_(NULL) for a in arg)
+        return self.if_(sg.or_(*any_args_null), NULL, self.f.concat(*arg))
+
     @visit_node.register(ops.Any)
     @visit_node.register(ops.All)
     @visit_node.register(ops.ApproxMedian)

diff --git a/ibis/backends/oracle/compiler.py b/ibis/backends/oracle/compiler.py
@@ -441,6 +441,11 @@ def visit_Window(self, op, *, how, func, start, end, group_by, order_by):
 
         return sge.Window(this=func, partition_by=group_by, order=order, spec=spec)
 
+    @visit_node.register(ops.StringConcat)
+    def visit_StringConcat(self, op, *, arg):
+        any_args_null = (a.is_(NULL) for a in arg)
+        return self.if_(sg.or_(*any_args_null), NULL, self.f.concat(*arg))
+
     @visit_node.register(ops.Arbitrary)
     @visit_node.register(ops.ArgMax)
     @visit_node.register(ops.ArgMin)