fix(polars): remove bogus minus-one-week truncation

ibis-project · Jul 23, 2024 · ac519b2 · ac519b2
1 parent e59a54c
commit ac519b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 29 deletions.
diff --git a/ibis/backends/polars/compiler.py b/ibis/backends/polars/compiler.py
@@ -865,7 +865,7 @@ def temporal_truncate(op, **kw):
     arg = translate(op.arg, **kw)
     unit = "mo" if op.unit.short == "M" else op.unit.short
     unit = f"1{unit.lower()}"
-    return arg.dt.truncate(unit).dt.offset_by("-1w")
+    return arg.dt.truncate(unit)
 
 
 def _compile_literal_interval(op):

diff --git a/ibis/backends/tests/test_temporal.py b/ibis/backends/tests/test_temporal.py
@@ -337,35 +337,20 @@ def test_timestamp_extract_week_of_year(backend, alltypes, df):
             "h",
             marks=[
                 pytest.mark.notimpl(["sqlite"], raises=com.UnsupportedOperationError),
-                pytest.mark.broken(
-                    ["polars"],
-                    raises=AssertionError,
-                    reason="numpy array are different",
-                ),
             ],
         ),
         param(
             "m",
             "min",
             marks=[
                 pytest.mark.notimpl(["sqlite"], raises=com.UnsupportedOperationError),
-                pytest.mark.broken(
-                    ["polars"],
-                    raises=AssertionError,
-                    reason="numpy array are different",
-                ),
             ],
         ),
         param(
             "s",
             "s",
             marks=[
                 pytest.mark.notimpl(["sqlite"], raises=com.UnsupportedOperationError),
-                pytest.mark.broken(
-                    ["polars"],
-                    raises=AssertionError,
-                    reason="numpy array are different",
-                ),
             ],
         ),
         param(
@@ -376,11 +361,6 @@ def test_timestamp_extract_week_of_year(backend, alltypes, df):
                     ["clickhouse", "mysql", "sqlite", "datafusion", "exasol"],
                     raises=com.UnsupportedOperationError,
                 ),
-                pytest.mark.broken(
-                    ["polars"],
-                    raises=AssertionError,
-                    reason="numpy array are different",
-                ),
             ],
         ),
         param(
@@ -391,11 +371,6 @@ def test_timestamp_extract_week_of_year(backend, alltypes, df):
                     ["clickhouse", "mysql", "sqlite", "trino", "datafusion", "exasol"],
                     raises=com.UnsupportedOperationError,
                 ),
-                pytest.mark.broken(
-                    ["polars"],
-                    raises=AssertionError,
-                    reason="numpy array are different",
-                ),
                 pytest.mark.notyet(
                     ["flink"],
                     raises=Py4JJavaError,
@@ -481,9 +456,7 @@ def test_timestamp_truncate(backend, alltypes, df, ibis_unit, pandas_unit):
         ),
     ],
 )
-@pytest.mark.broken(
-    ["polars", "druid"], reason="snaps to the UNIX epoch", raises=AssertionError
-)
+@pytest.mark.broken(["druid"], reason="snaps to the UNIX epoch", raises=AssertionError)
 @pytest.mark.broken(
     ["druid"],
     raises=AttributeError,