fix(clickhouse): check dispatching instead of membership in the regis…

…try for `has_operation`
ibis-project · Jul 28, 2023 · acb7f3f · acb7f3f
1 parent c1b7dbc
commit acb7f3f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ibis/backends/clickhouse/__init__.py b/ibis/backends/clickhouse/__init__.py
@@ -513,7 +513,7 @@ def _get_schema_using_query(self, query: str) -> sch.Schema:
     def has_operation(cls, operation: type[ops.Value]) -> bool:
         from ibis.backends.clickhouse.compiler.values import translate_val
 
-        return operation in translate_val.registry
+        return translate_val.dispatch(operation) is not translate_val.dispatch(object)
 
     def create_database(
         self, name: str, *, force: bool = False, engine: str = "Atomic"

diff --git a/ibis/backends/clickhouse/compiler/values.py b/ibis/backends/clickhouse/compiler/values.py
@@ -397,9 +397,9 @@ def _log(op, **kw):
 
 
 @translate_val.register(tuple)
-def _node_list(op, punct="()", **kw):
+def _node_list(op, **kw):
     values = ", ".join(map(_sql, map(partial(translate_val, **kw), op)))
-    return f"{punct[0]}{values}{punct[1]}"
+    return f"({values})"
 
 
 def _interval_format(op):