refactor(common): move tests for re_extract to general suite

ibis-project · May 19, 2023 · acd1774 · acd1774
1 parent 9be9bf0
commit acd1774
Show file tree

Hide file tree

Showing 3 changed files with 66 additions and 57 deletions.
diff --git a/ibis/backends/mysql/tests/conftest.py b/ibis/backends/mysql/tests/conftest.py
@@ -144,13 +144,3 @@ def con_nodb():
     return ibis.mysql.connect(
         host=MYSQL_HOST, user=MYSQL_USER, password=MYSQL_PASS, port=MYSQL_PORT
     )
-
-
-@pytest.fixture(scope='module')
-def alltypes(con):
-    return con.tables.functional_alltypes
-
-
-@pytest.fixture(scope='module')
-def df(alltypes):
-    return alltypes.execute()
diff --git a/ibis/backends/mysql/tests/test_string.py b/ibis/backends/mysql/tests/test_string.py
diff --git a/ibis/backends/tests/test_string.py b/ibis/backends/tests/test_string.py
@@ -252,6 +252,72 @@ def test_string_col_is_unicode(alltypes, df):
                 ),
             ],
         ),
+        param(
+            lambda t: t.date_string_col.re_extract(r'(\d+)\D(\d+)\D(\d+)', 1),
+            lambda t: t.date_string_col.str.extract(
+                r'(\d+)\D(\d+)\D(\d+)', expand=False
+            ).iloc[:, 0],
+            id='re_extract_group_1',
+            marks=[
+                pytest.mark.notimpl(
+                    ["mssql", "druid", "oracle"],
+                    raises=com.OperationNotDefinedError,
+                ),
+                pytest.mark.broken(["impala"], raises=AssertionError),
+            ],
+        ),
+        param(
+            lambda t: t.date_string_col.re_extract(r'(\d+)\D(\d+)\D(\d+)', 2),
+            lambda t: t.date_string_col.str.extract(
+                r'(\d+)\D(\d+)\D(\d+)', expand=False
+            ).iloc[:, 1],
+            id='re_extract_group_2',
+            marks=[
+                pytest.mark.notimpl(
+                    ["mssql", "druid", "oracle"],
+                    raises=com.OperationNotDefinedError,
+                ),
+                pytest.mark.broken(["impala", "clickhouse"], raises=AssertionError),
+            ],
+        ),
+        param(
+            lambda t: t.date_string_col.re_extract(r'(\d+)\D(\d+)\D(\d+)', 3),
+            lambda t: t.date_string_col.str.extract(
+                r'(\d+)\D(\d+)\D(\d+)', expand=False
+            ).iloc[:, 2],
+            id='re_extract_group_3',
+            marks=[
+                pytest.mark.notimpl(
+                    ["mssql", "druid", "oracle"],
+                    raises=com.OperationNotDefinedError,
+                ),
+                pytest.mark.broken(["impala", "clickhouse"], raises=AssertionError),
+            ],
+        ),
+        param(
+            lambda t: t.date_string_col.re_extract(r'^(\d+)', 1),
+            lambda t: t.date_string_col.str.extract(r'^(\d+)', expand=False),
+            id='re_extract_group_at_beginning',
+            marks=[
+                pytest.mark.notimpl(
+                    ["mssql", "druid", "oracle"],
+                    raises=com.OperationNotDefinedError,
+                ),
+                pytest.mark.broken(["impala"], raises=AssertionError),
+            ],
+        ),
+        param(
+            lambda t: t.date_string_col.re_extract(r'(\d+)$', 1),
+            lambda t: t.date_string_col.str.extract(r'(\d+)$', expand=False),
+            id='re_extract_group_at_end',
+            marks=[
+                pytest.mark.notimpl(
+                    ["mssql", "druid", "oracle"],
+                    raises=com.OperationNotDefinedError,
+                ),
+                pytest.mark.broken(["impala", "dask", "pandas"], raises=AssertionError),
+            ],
+        ),
         param(
             lambda t: t.string_col.re_replace(r'[[:digit:]]+', 'a'),
             lambda t: t.string_col.str.replace(r'\d+', 'a', regex=True),