Skip to content

Commit

Permalink
refactor(api): remove has_name (#10246)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: `has_name` has always returned `True` since 9.0. It is safe to remove any calls to `has_name`.
  • Loading branch information
cpcloud committed Sep 28, 2024
1 parent 76940ce commit adc2fd0
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions ibis/expr/types/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from ibis.config import _default_backend
from ibis.config import options as opts
from ibis.expr.format import pretty
from ibis.util import deprecated, experimental
from ibis.util import experimental

if TYPE_CHECKING:
from collections.abc import Iterator, Mapping
Expand Down Expand Up @@ -169,15 +169,6 @@ def __bool__(self) -> bool:

__nonzero__ = __bool__

@deprecated(
instead="remove any usage of `has_name`, since it is always `True`",
as_of="9.4",
removed_in="10.0",
)
def has_name(self):
"""Check whether this expression has an explicit name."""
return hasattr(self._arg, "name")

def get_name(self):
"""Return the name of this expression."""
return self._arg.name
Expand Down

0 comments on commit adc2fd0

Please sign in to comment.