feat(snowflake): implement proper approx median

ibis-project · Apr 25, 2023 · b15a6fe · b15a6fe
1 parent 41bacf2
commit b15a6fe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/ibis/backends/snowflake/registry.py b/ibis/backends/snowflake/registry.py
@@ -389,6 +389,7 @@ def _group_concat(t, op):
         ops.EndsWith: fixed_arity(sa.func.endswith, 2),
         ops.GroupConcat: _group_concat,
         ops.Hash: unary(sa.func.hash),
+        ops.ApproxMedian: reduction(lambda x: sa.func.approx_percentile(x, 0.5)),
     }
 )
 

diff --git a/ibis/backends/tests/test_aggregation.py b/ibis/backends/tests/test_aggregation.py
@@ -1010,7 +1010,7 @@ def test_corr_cov(
 
 
 @pytest.mark.notimpl(
-    ["datafusion", "mysql", "sqlite", "snowflake", "mssql", "druid"],
+    ["datafusion", "mysql", "sqlite", "mssql", "druid"],
     raises=com.OperationNotDefinedError,
 )
 @pytest.mark.broken(