feat(datafusion): implement ops.StringAscii

ibis-project · Feb 16, 2023 · b1d7672 · b1d7672
1 parent 2fe3fc4
commit b1d7672
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/ibis/backends/datafusion/compiler.py b/ibis/backends/datafusion/compiler.py
@@ -476,6 +476,11 @@ def string_translate(op):
     return df.functions.translate(*map(translate, op.args))
 
 
+@translate.register(ops.StringAscii)
+def string_ascii(op):
+    return df.functions.ascii(translate(op.arg))
+
+
 @translate.register(ops.RegexExtract)
 def regex_extract(op):
     arg = translate(op.arg)

diff --git a/ibis/backends/tests/test_string.py b/ibis/backends/tests/test_string.py
@@ -361,9 +361,7 @@ def test_string_col_is_unicode(alltypes, df):
             lambda t: t.string_col.ascii_str(),
             lambda t: t.string_col.map(ord).astype('int32'),
             id='ascii_str',
-            marks=pytest.mark.notimpl(
-                ["datafusion", "polars"], raises=com.OperationNotDefinedError
-            ),
+            marks=pytest.mark.notimpl(["polars"], raises=com.OperationNotDefinedError),
         ),
         param(
             lambda t: t.string_col.length(),