fix(trino,duckdb,postgres): make cumulative notany/notall aggrega…

…tions work
ibis-project · Mar 16, 2023 · c2e985f · c2e985f
1 parent e322f1d
commit c2e985f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/ibis/backends/base/sql/alchemy/registry.py b/ibis/backends/base/sql/alchemy/registry.py
@@ -369,8 +369,8 @@ def _window_function(t, window):
         end = _translate_window_boundary(window.frame.end)
         additional_params = {how: (start, end)}
 
-    result = reduction.over(
-        partition_by=partition_by, order_by=order_by, **additional_params
+    result = sa.over(
+        reduction, partition_by=partition_by, order_by=order_by, **additional_params
     )
 
     if isinstance(window.func, (ops.RowNumber, ops.DenseRank, ops.MinRank, ops.NTile)):

diff --git a/ibis/backends/tests/test_window.py b/ibis/backends/tests/test_window.py
@@ -155,14 +155,11 @@ def calc_zscore(s):
             id='cumnotany',
             marks=pytest.mark.notyet(
                 (
-                    "duckdb",
                     'impala',
-                    'postgres',
                     'mssql',
                     'mysql',
                     'sqlite',
                     'snowflake',
-                    'trino',
                 ),
                 reason="notany() over window not supported",
             ),
@@ -188,14 +185,11 @@ def calc_zscore(s):
             id='cumnotall',
             marks=pytest.mark.notyet(
                 (
-                    "duckdb",
                     'impala',
-                    'postgres',
                     'mssql',
                     'mysql',
                     'sqlite',
                     'snowflake',
-                    'trino',
                 ),
                 reason="notall() over window not supported",
             ),