feat: improve generated column names for methods receiving intervals

ibis-project · Oct 20, 2023 · c319ed3 · c319ed3
1 parent 09881b0
commit c319ed3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ibis/expr/operations/generic.py b/ibis/expr/operations/generic.py
@@ -190,6 +190,8 @@ def __init__(self, value, dtype):
 
     @property
     def name(self):
+        if self.dtype.is_interval():
+            return f"{self.value!r}{self.dtype.unit.short}"
         return repr(self.value)
 
 

diff --git a/ibis/expr/types/core.py b/ibis/expr/types/core.py
@@ -622,9 +622,9 @@ def _binop(op_class: type[ops.Binary], left: ir.Value, right: ir.Value) -> ir.Va
     >>> import ibis.expr.operations as ops
     >>> expr = _binop(ops.TimeAdd, ibis.time("01:00"), ibis.interval(hours=1))
     >>> expr
-    TimeAdd(datetime.time(1, 0), 1): datetime.time(1, 0) + 1 h
+    TimeAdd(datetime.time(1, 0), 1h): datetime.time(1, 0) + 1 h
     >>> _binop(ops.TimeAdd, 1, ibis.interval(hours=1))
-    TimeAdd(datetime.time(0, 0, 1), 1): datetime.time(0, 0, 1) + 1 h
+    TimeAdd(datetime.time(0, 0, 1), 1h): datetime.time(0, 0, 1) + 1 h
     """
     try:
         node = op_class(left, right)