feat(snowflake): implement ArrayCollect

ibis-project · Jan 18, 2023 · c425f68 · c425f68
1 parent a72c844
commit c425f68
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/ibis/backends/snowflake/registry.py b/ibis/backends/snowflake/registry.py
@@ -214,6 +214,7 @@ def _map(_, op):
             *map(t.translate, op.cols)
         ),
         ops.ArraySlice: _array_slice,
+        ops.ArrayCollect: reduction(sa.func.array_agg),
         ops.Map: _map,
     }
 )
@@ -231,7 +232,6 @@ def _map(_, op):
     # ibis.expr.operations.reductions
     ops.All,
     ops.Any,
-    ops.ArrayCollect,
     ops.BitAnd,
     ops.BitOr,
     ops.BitXor,

diff --git a/ibis/backends/tests/test_aggregation.py b/ibis/backends/tests/test_aggregation.py
@@ -495,15 +495,7 @@ def mean_and_std(v):
             id="collect",
             marks=[
                 mark.notimpl(
-                    [
-                        "dask",
-                        "impala",
-                        "mysql",
-                        "snowflake",
-                        "sqlite",
-                        "datafusion",
-                        "mssql",
-                    ]
+                    ["dask", "impala", "mysql", "sqlite", "datafusion", "mssql"]
                 )
             ],
         ),