refactor(sqlalchemy): remove unnecessary _AutoCloseCursor #2947

ibis/backends/base/sql/alchemy/__init__.py

@@ -52,28 +52,6 @@
 )
 
 
-class _AutoCloseCursor:
-    """
-    Wraps a SQLAlchemy ResultProxy and ensures that .close() is called on
-    garbage collection
-    """
-
-    def __init__(self, original_cursor):
-        self.original_cursor = original_cursor
-
-    def __del__(self):
-        self.original_cursor.close()
-
-    def __enter__(self):
-        return self
-
-    def __exit__(self, type, value, tb):
-        self.original_cursor.close()
-
-    def fetchall(self):
-        return self.original_cursor.fetchall()
-
-
 class BaseAlchemyBackend(BaseSQLBackend):
     """
     Base backend class for backends that compile to SQL with SQLAlchemy.
@@ -151,8 +129,8 @@ def to_shapely(row, name):
 
     def fetch_from_cursor(self, cursor, schema):
         df = pd.DataFrame.from_records(
-            cursor.original_cursor.fetchall(),
-            columns=cursor.original_cursor.keys(),
+            cursor.fetchall(),
+            columns=cursor.keys(),
             coerce_float=True,
         )
         df = schema.apply_to(df)
@@ -326,9 +304,6 @@ def current_database(self):
     def list_schemas(self):
         return self.list_databases()
 
-    def raw_sql(self, query: str, results=False):
-        return _AutoCloseCursor(super().raw_sql(query))
-
     def _log(self, sql):
         try:
             query_str = str(sql)