Skip to content

Commit

Permalink
style(sqlalchemy): clean up arguments
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud authored and kszucs committed May 23, 2022
1 parent a4d44a0 commit dd1f3bc
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions ibis/backends/base/sql/alchemy/registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -591,10 +591,10 @@ def _nth_value(t, expr):
ops.NTile: _ntile,
ops.FirstValue: unary(sa.func.first_value),
ops.LastValue: unary(sa.func.last_value),
ops.RowNumber: fixed_arity(lambda: sa.func.row_number(), 0),
ops.DenseRank: unary(lambda arg: sa.func.dense_rank()),
ops.MinRank: unary(lambda arg: sa.func.rank()),
ops.PercentRank: unary(lambda arg: sa.func.percent_rank()),
ops.RowNumber: fixed_arity(sa.func.row_number, 0),
ops.DenseRank: unary(lambda _: sa.func.dense_rank()),
ops.MinRank: unary(lambda _: sa.func.rank()),
ops.PercentRank: unary(lambda _: sa.func.percent_rank()),
ops.NthValue: _nth_value,
ops.Window: _window,
ops.CumulativeOp: _window,
Expand Down

1 comment on commit dd1f3bc

@ibis-squawk-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 3.

Benchmark suite Current: dd1f3bc Previous: 37ff328 Ratio
ibis/tests/benchmarks/test_benchmarks.py::test_large_expr_equals 6149.322131148192 iter/sec (stddev: 0.004194103556425064) 547458.7394785702 iter/sec (stddev: 7.487876991216325e-7) 89.03

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.