feat(clickhouse): implement table union

ibis-project · Mar 18, 2022 · e0008d7 · e0008d7
1 parent a5b7293
commit e0008d7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/ibis/backends/clickhouse/compiler.py b/ibis/backends/clickhouse/compiler.py
@@ -9,9 +9,16 @@
     TableSetFormatter,
 )
 
+from ..base.sql.compiler.query_builder import Union
 from .registry import operation_registry
 
 
+class ClickhouseUnion(Union):
+    @staticmethod
+    def keyword(distinct):
+        return 'UNION DISTINCT' if distinct else 'UNION ALL'
+
+
 class ClickhouseSelectBuilder(SelectBuilder):
     def _convert_group_by(self, exprs):
         return exprs
@@ -116,3 +123,4 @@ class ClickhouseCompiler(Compiler):
     table_set_formatter_class = ClickhouseTableSetFormatter
     select_builder_class = ClickhouseSelectBuilder
     select_class = ClickhouseSelect
+    union_class = ClickhouseUnion
diff --git a/ibis/backends/tests/test_union.py b/ibis/backends/tests/test_union.py
@@ -4,7 +4,7 @@
 
 
 @pytest.mark.parametrize('distinct', [False, True])
-@pytest.mark.notimpl(["clickhouse", "datafusion"])
+@pytest.mark.notimpl(["datafusion"])
 def test_union(backend, alltypes, df, distinct):
     result = alltypes.union(alltypes, distinct=distinct).execute()
     expected = df if distinct else pd.concat([df, df], axis=0)
@@ -29,7 +29,7 @@ def test_union(backend, alltypes, df, distinct):
         ),
     ],
 )
-@pytest.mark.notimpl(["clickhouse", "datafusion"])
+@pytest.mark.notimpl(["datafusion"])
 def test_union_no_sort(backend, alltypes, df, distinct):
     result = alltypes.union(alltypes, distinct=distinct).execute()
     expected = df if distinct else pd.concat([df, df], axis=0)