Skip to content

Commit

Permalink
fix(polars): polars no longer panics on a value_counts-ed expression
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed Aug 21, 2023
1 parent 7b2d18a commit e14185a
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions ibis/backends/tests/test_aggregation.py
Original file line number Diff line number Diff line change
Expand Up @@ -1483,11 +1483,6 @@ def test_group_concat_over_window(backend, con):


@pytest.mark.notimpl(["dask"], raises=NotImplementedError)
@pytest.mark.notyet(
["polars"],
reason="polars panics",
raises=BaseException, # BaseException is required to catch the panic
)
def test_value_counts_on_expr(backend, alltypes, df):
expr = alltypes.bigint_col.add(1).value_counts()
columns = expr.columns
Expand Down

0 comments on commit e14185a

Please sign in to comment.