fix(impala): allow specifying temp=False in create_table

ibis-project · Sep 6, 2024 · e29712c · e29712c
1 parent 159789b
commit e29712c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ibis/backends/impala/__init__.py b/ibis/backends/impala/__init__.py
@@ -513,7 +513,7 @@ def create_table(
         if schema is not None:
             schema = ibis.schema(schema)
 
-        if temp is not None:
+        if temp:
             raise NotImplementedError(
                 "Impala backend does not yet support temporary tables"
             )

diff --git a/ibis/backends/tests/test_client.py b/ibis/backends/tests/test_client.py
@@ -119,7 +119,7 @@ def test_create_table(backend, con, temp_table, func, sch):
             marks=[
                 pytest.mark.notyet(["clickhouse"], reason="Can't specify both"),
                 pytest.mark.notyet(
-                    ["pyspark", "trino", "exasol", "risingwave"],
+                    ["pyspark", "trino", "exasol", "risingwave", "impala"],
                     reason="No support for temp tables",
                 ),
                 pytest.mark.notyet(
@@ -145,7 +145,7 @@ def test_create_table(backend, con, temp_table, func, sch):
             id="temp, no overwrite",
             marks=[
                 pytest.mark.notyet(
-                    ["pyspark", "trino", "exasol", "risingwave"],
+                    ["pyspark", "trino", "exasol", "risingwave", "impala"],
                     reason="No support for temp tables",
                 ),
                 pytest.mark.notimpl(["mssql"], reason="Incorrect temp table syntax"),
@@ -157,7 +157,7 @@ def test_create_table(backend, con, temp_table, func, sch):
         ),
     ],
 )
-@pytest.mark.notimpl(["druid", "impala"])
+@pytest.mark.notimpl(["druid"])
 def test_create_table_overwrite_temp(backend, con, temp_table, temp, overwrite):
     df = pd.DataFrame(
         {