feat(clickhouse): improve error message for invalid types in literal

ibis-project · Jan 28, 2023 · e4d7799 · e4d7799
1 parent addd6a9
commit e4d7799
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/ibis/backends/clickhouse/compiler/values.py b/ibis/backends/clickhouse/compiler/values.py
@@ -454,7 +454,7 @@ def _literal(op, **kw):
         fields = ", ".join(f"{value} as `{key}`" for key, value in op.value.items())
         return f"tuple({fields})"
     else:
-        raise NotImplementedError(type(op))
+        raise NotImplementedError(f'Unsupported type: {dtype!r}')
 
 
 def _array_literal_values(op):

diff --git a/ibis/backends/tests/test_generic.py b/ibis/backends/tests/test_generic.py
@@ -1036,12 +1036,7 @@ def test_exists(batting, awards_players, method_name):
                     raises=sqlalchemy.exc.StatementError,
                 ),
                 pytest.mark.broken(
-                    ['clickhouse'],
-                    "<class 'ibis.expr.operations.generic.Literal'>",
-                    raises=NotImplementedError,
-                ),
-                pytest.mark.broken(
-                    ['impala'],
+                    ['clickhouse', 'impala'],
                     "Unsupported type: Binary(nullable=True)",
                     raises=NotImplementedError,
                 ),
@@ -1160,12 +1155,7 @@ def test_exists(batting, awards_players, method_name):
                     raises=ProgrammingError,
                 ),
                 pytest.mark.broken(
-                    ['clickhouse'],
-                    "<class 'ibis.expr.operations.generic.Literal'>",
-                    raises=NotImplementedError,
-                ),
-                pytest.mark.broken(
-                    ['impala'],
+                    ['clickhouse', 'impala'],
                     "Unsupported type: UUID(nullable=True)",
                     raises=NotImplementedError,
                 ),