fix(snowflake): don't always insert a cast

ibis-project · Jan 18, 2023 · ee8817b · ee8817b
1 parent 7ae6e25
commit ee8817b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/ibis/backends/base/sql/alchemy/registry.py b/ibis/backends/base/sql/alchemy/registry.py
@@ -184,6 +184,10 @@ def _cast(t, op):
 
     if typ.is_json() and not t.native_json_type:
         return sa_arg
+
+    ignore_cast_types = t._ignore_cast_types
+    if ignore_cast_types and isinstance(typ, ignore_cast_types):
+        return sa_arg
     return sa.cast(sa_arg, sa_type)
 
 

diff --git a/ibis/backends/base/sql/alchemy/translator.py b/ibis/backends/base/sql/alchemy/translator.py
@@ -45,6 +45,7 @@ class AlchemyExprTranslator(ExprTranslator):
     integer_to_timestamp = sa.func.to_timestamp
     native_json_type = True
     _always_quote_columns = False
+    _ignore_cast_types = ()
 
     _require_order_by = (
         ops.DenseRank,

diff --git a/ibis/backends/snowflake/__init__.py b/ibis/backends/snowflake/__init__.py
@@ -8,6 +8,7 @@
 import toolz
 from snowflake.sqlalchemy import URL
 
+import ibis.expr.datatypes as dt
 import ibis.expr.operations as ops
 import ibis.expr.schema as sch
 from ibis.backends.base.sql.alchemy import (
@@ -38,6 +39,7 @@ class SnowflakeExprTranslator(AlchemyExprTranslator):
         ops.Lead,
     )
     _require_order_by = (*AlchemyExprTranslator._require_order_by, ops.Reduction)
+    _ignore_cast_types = (dt.Map, dt.Array)
 
 
 class SnowflakeCompiler(AlchemyCompiler):