feat(exasol): add support for extract seconds (#8723)

ibis-project · Mar 21, 2024 · fb7e533 · fb7e533
1 parent 1778de5
commit fb7e533
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/ibis/backends/exasol/compiler.py b/ibis/backends/exasol/compiler.py
@@ -154,7 +154,7 @@ def visit_StringContains(self, op, *, haystack, needle):
         return self.f.locate(needle, haystack) > 0
 
     def visit_ExtractSecond(self, op, *, arg):
-        return self.f.floor(self.cast(self.f.extract(self.v.second, arg), op.dtype))
+        return self.cast(self.f.floor(self.f.extract(self.v.second, arg)), op.dtype)
 
     def visit_ExtractMillisecond(self, op, *, arg):
         return self.cast(

diff --git a/ibis/backends/tests/test_temporal.py b/ibis/backends/tests/test_temporal.py
@@ -81,16 +81,7 @@ def test_date_extract(backend, alltypes, df, attr, expr_fn):
         ),
         "hour",
         "minute",
-        param(
-            "second",
-            marks=[
-                pytest.mark.broken(
-                    ["exasol"],
-                    raises=AssertionError,
-                    reason="seems like exasol might be rounding",
-                )
-            ],
-        ),
+        "second",
     ],
 )
 @pytest.mark.notimpl(