Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move the coercion functions from schema.py to udf.py #3033

Closed
kszucs opened this issue Oct 1, 2021 · 3 comments · Fixed by #3387
Closed

refactor: move the coercion functions from schema.py to udf.py #3033

kszucs opened this issue Oct 1, 2021 · 3 comments · Fixed by #3387
Assignees
@EdAbati
Labels
onboarding Issues that can be addressed by someone less familiar with ibis refactor Issues or PRs related to refactoring the codebase

Comments

@kszucs
Copy link
Member

kszucs commented Oct 1, 2021

These are data manipulating routines related to UDFs.
@cpcloud cpcloud added onboarding Issues that can be addressed by someone less familiar with ibis refactor Issues or PRs related to refactoring the codebase labels Nov 22, 2021
@cpcloud cpcloud changed the title Move the coercion functions from schema.py to udf.py refactor: move the coercion functions from schema.py to udf.py Dec 28, 2021
@cpcloud
Copy link
Member

cpcloud commented Jan 25, 2022

@kszucs Should we keep this open?

@kszucs
Copy link
Member Author

kszucs commented Jan 25, 2022

Yes, I think we need to find a new place for these routines.

@EdAbati
Copy link
Contributor

EdAbati commented Feb 1, 2022

/take

EdAbati added a commit to EdAbati/ibis that referenced this issue Feb 1, 2022
@EdAbati
refactor: moving coercion functions from schema.py to udf
7b38c1e 
fixes ibis-project#3033
@EdAbati EdAbati mentioned this issue Feb 1, 2022
Merged
cpcloud pushed a commit to EdAbati/ibis that referenced this issue Feb 7, 2022
@EdAbati @cpcloud
refactor: move coercion functions from schema.py to udf
34a1e23 
fixes ibis-project#3033

BREAKING CHANGE: coercion functions previously in expr/schema.py are now in udf/vectorized.py
cpcloud pushed a commit that referenced this issue Feb 7, 2022
@EdAbati @cpcloud
refactor: move coercion functions from schema.py to udf
58eea56 
fixes #3033

BREAKING CHANGE: coercion functions previously in expr/schema.py are now in udf/vectorized.py
saulpw pushed a commit to saulpw/ibis that referenced this issue Feb 8, 2022
@EdAbati
refactor: move coercion functions from schema.py to udf
d740a46 
fixes ibis-project#3033

BREAKING CHANGE: coercion functions previously in expr/schema.py are now in udf/vectorized.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EdAbati EdAbati

Labels
onboarding Issues that can be addressed by someone less familiar with ibis refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move coercion functions from schema.py to udf EdAbati/ibis
3 participants
@cpcloud @kszucs @EdAbati