Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api): remove by argument of asof_join in favor of predicates #7869

Closed
kszucs opened this issue Dec 30, 2023 · 0 comments · Fixed by #8700
Closed

refactor(api): remove by argument of asof_join in favor of predicates #7869

kszucs opened this issue Dec 30, 2023 · 0 comments · Fixed by #8700
Assignees
@mfatihaktas
Labels
expressions Issues or PRs related to the expression API onboarding Issues that can be addressed by someone less familiar with ibis
Milestone
9.0

Comments

@kszucs
Copy link
Member

kszucs commented Dec 30, 2023 

          Can we get rid of `by`? Having that alongside `predicates` and `on` seems a bit confusing.

Originally posted by @cpcloud in #7859 (comment)
@kszucs kszucs added the tes-required-for-release Things that must be addressed before *release* of `main` after merging in `the-epic-split` label Dec 30, 2023
@kszucs kszucs mentioned this issue Dec 30, 2023
Merged
@cpcloud cpcloud added the tes-required-for-merge Issues that must addressed before merging the-epic-split branch into main label Jan 8, 2024
@jcrist jcrist removed the tes-required-for-merge Issues that must addressed before merging the-epic-split branch into main label Jan 30, 2024
@jcrist jcrist added this to the 9.0 milestone Jan 30, 2024
@jcrist jcrist added expressions Issues or PRs related to the expression API and removed tes-required-for-release Things that must be addressed before *release* of `main` after merging in `the-epic-split` labels Jan 30, 2024
@jcrist jcrist added the onboarding Issues that can be addressed by someone less familiar with ibis label Mar 6, 2024
@mfatihaktas mfatihaktas self-assigned this Mar 7, 2024
@mfatihaktas mfatihaktas moved this from backlog to todo in Ibis planning and roadmap Mar 7, 2024
@mfatihaktas mfatihaktas moved this from todo to cooking in Ibis planning and roadmap Mar 19, 2024
@mfatihaktas mfatihaktas mentioned this issue Mar 19, 2024
Merged
cpcloud pushed a commit that referenced this issue Mar 20, 2024
@mfatihaktas
refactor(api): remove by of asof_join() in favor of predicates (#…
1a8eec8 
…8700)

Closes #7869.

BREAKING CHANGE: The `by` argument from `asof_join` is removed. Calls to `asof_join` that previously used `by` should pass those arguments to `predicates` instead.
@github-project-automation github-project-automation bot moved this from cooking to done in Ibis planning and roadmap Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfatihaktas mfatihaktas

Labels
expressions Issues or PRs related to the expression API onboarding Issues that can be addressed by someone less familiar with ibis
Projects
Ibis planning and roadmap
Archived in project
Milestone
9.0
Development

Successfully merging a pull request may close this issue.

refactor(api): remove by of asof_join() in favor of predicates mfatihaktas/ibis
4 participants
@cpcloud @kszucs @jcrist @mfatihaktas