refactor(sqlglot): various sqlglot compiler and backend clean ups #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions for greater backend compatibility
…l compilation in base sqlglot compiler class
kszucs
reviewed
Jan 4, 2024
… to allow redundant compiler rule cleanup
… to the class directly
…iled with dangling spans
…to not render to allow backends that hard-restrict such bounds to execute
kszucs
reviewed
Jan 4, 2024
| return func(*args, dialect=self.dialect) | ||
|
|
||
| @staticmethod | ||
| def _minimize_spec(start, end, spec): |
There was a problem hiding this comment.
Shouldn't this be a rewrite instead?
There was a problem hiding this comment.
Can you propose a rewrite rule? I'm not sure this can be done as a rewrite: it's altering the way specific ibis values are interpreted in sqlglot.
There was a problem hiding this comment.
Ahh, this changes the sqlglot expression. Then can you rename the method to _minimize_window_spec and add a short comment about what it does?
cpcloud
force-pushed
the
consolidate-sqlglot
branch
from
d614257 to
9eafdcd
Compare
cpcloud
force-pushed
the
consolidate-sqlglot
branch
from
487e1d8 to
6e9e9bc
Compare
kszucs
approved these changes
Jan 4, 2024
cpcloud
added a commit
that referenced
this pull request
Jan 5, 2024
) This PR pulls out some changes from #7871, including some removal of redundant translation rules and fixing some xpassing tests
cpcloud
added a commit
that referenced
this pull request
Jan 12, 2024
) This PR pulls out some changes from #7871, including some removal of redundant translation rules and fixing some xpassing tests
cpcloud
added a commit
that referenced
this pull request
Jan 13, 2024
) This PR pulls out some changes from #7871, including some removal of redundant translation rules and fixing some xpassing tests
cpcloud
added a commit
that referenced
this pull request
Jan 17, 2024
) This PR pulls out some changes from #7871, including some removal of redundant translation rules and fixing some xpassing tests
kszucs
pushed a commit
to kszucs/ibis
that referenced
this pull request
Feb 1, 2024
…is-project#7904) This PR pulls out some changes from ibis-project#7871, including some removal of redundant translation rules and fixing some xpassing tests
kszucs
pushed a commit
to kszucs/ibis
that referenced
this pull request
Feb 1, 2024
…is-project#7904) This PR pulls out some changes from ibis-project#7871, including some removal of redundant translation rules and fixing some xpassing tests
kszucs
pushed a commit
to kszucs/ibis
that referenced
this pull request
Feb 1, 2024
…is-project#7904) This PR pulls out some changes from ibis-project#7871, including some removal of redundant translation rules and fixing some xpassing tests
kszucs
pushed a commit
to kszucs/ibis
that referenced
this pull request
Feb 2, 2024
…is-project#7904) This PR pulls out some changes from ibis-project#7871, including some removal of redundant translation rules and fixing some xpassing tests
kszucs
pushed a commit
to kszucs/ibis
that referenced
this pull request
Feb 2, 2024
…is-project#7904) This PR pulls out some changes from ibis-project#7871, including some removal of redundant translation rules and fixing some xpassing tests
kszucs
pushed a commit
to kszucs/ibis
that referenced
this pull request
Feb 2, 2024
…is-project#7904) This PR pulls out some changes from ibis-project#7871, including some removal of redundant translation rules and fixing some xpassing tests
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Feb 4, 2024
…is-project#7904) This PR pulls out some changes from ibis-project#7871, including some removal of redundant translation rules and fixing some xpassing tests
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Feb 5, 2024
…is-project#7904) This PR pulls out some changes from ibis-project#7871, including some removal of redundant translation rules and fixing some xpassing tests
kszucs
pushed a commit
that referenced
this pull request
Feb 5, 2024
) This PR pulls out some changes from #7871, including some removal of redundant translation rules and fixing some xpassing tests
kszucs
pushed a commit
that referenced
this pull request
Feb 6, 2024
) This PR pulls out some changes from #7871, including some removal of redundant translation rules and fixing some xpassing tests
kszucs
pushed a commit
that referenced
this pull request
Feb 6, 2024
) This PR pulls out some changes from #7871, including some removal of redundant translation rules and fixing some xpassing tests
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Feb 12, 2024
…is-project#7904) This PR pulls out some changes from ibis-project#7871, including some removal of redundant translation rules and fixing some xpassing tests
cpcloud
added a commit
that referenced
this pull request
Feb 12, 2024
) This PR pulls out some changes from #7871, including some removal of redundant translation rules and fixing some xpassing tests
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Feb 12, 2024
…is-project#7904) This PR pulls out some changes from ibis-project#7871, including some removal of redundant translation rules and fixing some xpassing tests
cpcloud
added a commit
that referenced
this pull request
Feb 12, 2024
) This PR pulls out some changes from #7871, including some removal of redundant translation rules and fixing some xpassing tests
kszucs
pushed a commit
that referenced
this pull request
Feb 12, 2024
) This PR pulls out some changes from #7871, including some removal of redundant translation rules and fixing some xpassing tests
ncclementi
pushed a commit
to ncclementi/ibis
that referenced
this pull request
Feb 21, 2024
…is-project#7904) This PR pulls out some changes from ibis-project#7871, including some removal of redundant translation rules and fixing some xpassing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls out some changes from #7871, including some removal of redundant translation rules and fixing some xpassing tests