test(markers): test the test markers #8077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
I had a thought about a potential edge case with `None` being the only listed "Exception" in a `raises` argument. This fixes the edge case and also adds some simple tests to make sure our custom markers correctly handle when an imported backend exception is set to `None` due to a missing import.
gforsyth
force-pushed
the
test_the_test_markers
branch
from
a8bb0b7 to
421d6e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a thought about a potential edge case with
Nonebeing the onlylisted "Exception" in a
raisesargument. This fixes the edge case andalso adds some simple tests to make sure our custom markers correctly
handle when an imported backend exception is set to
Nonedue to amissing import.