Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): verify the accuracy of the support matrix in the-epic-split #8283

Closed
cpcloud opened this issue Feb 8, 2024 · 1 comment · Fixed by #8338
Closed

chore(docs): verify the accuracy of the support matrix in the-epic-split #8283

cpcloud opened this issue Feb 8, 2024 · 1 comment · Fixed by #8338
Assignees
@cpcloud
Labels
docs Documentation related issues or PRs tes-required-for-release Things that must be addressed before *release* of `main` after merging in `the-epic-split`
Milestone
9.0

Comments

@cpcloud
Copy link
Member

cpcloud commented Feb 8, 2024

The matrix isn't as accurate with the-epic-split, which we should address to the extent possible before releasing 9.0.
@cpcloud cpcloud added docs Documentation related issues or PRs tes-required-for-release Things that must be addressed before *release* of `main` after merging in `the-epic-split` labels Feb 8, 2024
@cpcloud cpcloud added this to the 9.0 milestone Feb 8, 2024
@gforsyth
Copy link
Member

We should fix the matrix, but I suggest that we:

  1. Confirm that all backends show 100% -- if they don't we should make sure that they do. E.g. all backends should have all ops mapped, even if many (most) are mapped to a NotImplementedError.
  2. Then add a filter has_operation to filter out results that raise

@cpcloud cpcloud mentioned this issue Feb 13, 2024
Merged
kszucs pushed a commit that referenced this issue Feb 14, 2024
@cpcloud
refactor(backends): remove singledispatchmethod from the sql backends (…
78dc393 
…#8338)

## Description of changes

This pull request does two things:

1. Removes use of `singledispatchmethod` in the SQL compilers
1. Fixes the support matrix accuracy for SQL backends

Follow-ups:

* ~Deal with filtering out RisingWave geospatial~ Handled here
* `__init_subclass__` for `SIMPLE_OPS` handled here
* Fix coverage accuracy for the non-SQL backends

## Issues closed

Fixes #8283.

Thanks to @jcrist for the `__init_subclass__` tip, that saved N backends
duplication of filling in undefined operations.
@github-project-automation github-project-automation bot moved this from backlog to done in Ibis planning and roadmap Feb 14, 2024
ncclementi pushed a commit to ncclementi/ibis that referenced this issue Feb 21, 2024
@cpcloud @ncclementi
refactor(backends): remove singledispatchmethod from the sql backends (…
996c861 
…ibis-project#8338)

## Description of changes

This pull request does two things:

1. Removes use of `singledispatchmethod` in the SQL compilers
1. Fixes the support matrix accuracy for SQL backends

Follow-ups:

* ~Deal with filtering out RisingWave geospatial~ Handled here
* `__init_subclass__` for `SIMPLE_OPS` handled here
* Fix coverage accuracy for the non-SQL backends

## Issues closed

Fixes ibis-project#8283.

Thanks to @jcrist for the `__init_subclass__` tip, that saved N backends
duplication of filling in undefined operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpcloud cpcloud

Labels
docs Documentation related issues or PRs tes-required-for-release Things that must be addressed before *release* of `main` after merging in `the-epic-split`
Projects
Ibis planning and roadmap
Archived in project
Milestone
9.0
Development

Successfully merging a pull request may close this issue.

refactor(backends): remove singledispatchmethod from the sql backends cpcloud/ibis
2 participants
@cpcloud @gforsyth