refactor(backends): remove singledispatchmethod from the sql backends #8338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
refactor
cpcloud
force-pushed
the
cleanup-sql-support-matrix
branch
3 times, most recently
from
2b0466a to
f986a1e
Compare
ibis-docs-bot
bot
removed
the
docs-preview
cpcloud
force-pushed
the
cleanup-sql-support-matrix
branch
from
f986a1e to
6524e90
Compare
ibis-docs-bot
bot
removed
the
docs-preview
cpcloud
force-pushed
the
cleanup-sql-support-matrix
branch
from
6524e90 to
b71bc5b
Compare
cpcloud
force-pushed
the
cleanup-sql-support-matrix
branch
from
b71bc5b to
d64e078
Compare
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
cpcloud
force-pushed
the
cleanup-sql-support-matrix
branch
from
d64e078 to
1b0a137
Compare
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
kszucs
pushed a commit
that referenced
this pull request
Feb 14, 2024
Follow up to #8338 to clean up the SIMPLE_OPS boilerplate.
ncclementi
pushed a commit
to ncclementi/ibis
that referenced
this pull request
Feb 21, 2024
…ibis-project#8338) ## Description of changes This pull request does two things: 1. Removes use of `singledispatchmethod` in the SQL compilers 1. Fixes the support matrix accuracy for SQL backends Follow-ups: * ~Deal with filtering out RisingWave geospatial~ Handled here * `__init_subclass__` for `SIMPLE_OPS` handled here * Fix coverage accuracy for the non-SQL backends ## Issues closed Fixes ibis-project#8283. Thanks to @jcrist for the `__init_subclass__` tip, that saved N backends duplication of filling in undefined operations.
ncclementi
pushed a commit
to ncclementi/ibis
that referenced
this pull request
Feb 21, 2024
…ject#8349) Follow up to ibis-project#8338 to clean up the SIMPLE_OPS boilerplate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This pull request does two things:
singledispatchmethodin the SQL compilersFollow-ups:
Deal with filtering out RisingWave geospatialHandled here__init_subclass__forSIMPLE_OPShandled hereIssues closed
Fixes #8283.
Thanks to @jcrist for the
__init_subclass__tip, that saved N backends duplication of filling in undefined operations.