-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make args required-keywords in make read_postgres
, read_sqlite
to be consistent with read_mysql
#8712
Comments
…ite (#8829) In #8656 we made the args for `read_mysql` required-keyword. This PR, makes the args for `read_postgres` and `read_sqlite` to be required-keyword to be consistent. It also fixes a broken test that runs only locally, `test_read_postgres` (thanks @gforsyth for the patch suggestion). - Closes #8712
Not clear that this "consistency" is helpful, as it introduces inconsistencies elsewhere. If you search here, you will see many references to |
Hey @iangow -- hopefully on that page any reference to If there are any remaining references to schema as a hierarchical location mapping, those should definitely be removed. |
It seems there are several places where this is not the case. Sometimes this argument is listed as Not sure that every PostgreSQL user ( |
This note appears at times: ::: {.callout-note} It doesn't render properly in most cases. It looks good under |
If an API is marked experimental we may have just removed it outright -- I'll look at the docs rendering issues and also add a note to |
…9133) Callouts inside of a parameter description aren't being rendered in the docs, so I've moved this callout into the main body of the docstring so it renders correctly. I've also added the same callout to the `read_postgres` method on the DuckDB backend, as postgres users may try to use `schema` in the hierarchical sense. xref #8712
Recently, in #8656 we discussed making the arguments of
read_mysql
required-keywords, and agreed that as a followup we will make this consistent inread_postgres
andread_sqlite
.Action Item:
read_postgres
andread_sqlite
required-keywordThe text was updated successfully, but these errors were encountered: