Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update links to duckdb csv parameters #8732

Closed
1 task done
amoeba opened this issue Mar 21, 2024 · 0 comments · Fixed by #8733
Closed
1 task done

docs: update links to duckdb csv parameters #8732

amoeba opened this issue Mar 21, 2024 · 0 comments · Fixed by #8733
Labels
docs Documentation related issues or PRs

Comments

@amoeba
Copy link
Contributor

amoeba commented Mar 21, 2024

Please describe the issue

There are two locations in docstrings where Ibis links to https://duckdb.org/docs/data/csv#parameters.

  • ibis/expr/api.py
  • ibis/backends/duckdb/__init__.py

If you visit this URL in a browser, you get redirected to https://duckdb.org/docs/data/csv/overview.html but are missing the #parameters fragment so you aren't scrolled to the intended section of the page, https://duckdb.org/docs/data/csv/overview.html#parameters. This is because DuckDB changed this URL at some point and, when they set up the redirect, they didn't set it up in such a way as to preserve fragments.

I'll put up a PR in a sec to change the URLs.

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant