-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(presentations): presentation for linkedin meetup 2024-04-24 #8983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive-by review -- looks pretty slick!
I don't see why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few initial feedbacks -- main thing is some of the code not executing/showing. this looks awesome! love that we can code-review presentations :) and put them right on the website
::: {.fragment .fade-in-then-semi-out} | ||
```{python} | ||
#| echo: true | ||
ibis.to_sql(expr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the output here is going off the slide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's intentional for now.
fb0bb46
to
17bace0
Compare
I'll poke around for a minute on whether the title on the page can be different from the presentation title, but if not, I'll probably just change the titles or leave it as is. |
Co-authored-by: Chloe He <chloe@chloe-mac.lan> Co-authored-by: Chloe He <chloe@chloe-mac.lan1>
cfef8f5
to
4d97b8f
Compare
…n feedback (#26) <!-- Thanks for taking the time to contribute to Ibis! Please ensure that your pull request title matches the conventional commits specification: https://www.conventionalcommits.org/en/v1.0.0/ --> ## Description of changes <!-- Write a description of the changes commensurate with the pull request's scope. Extremely small changes such as fixing typos do not need a description. --> ## Issues closed <!-- Please add Resolves #<issue number> (no angle brackets) if this pull request resolves any outstanding issues. For example, if your pull requests resolves issues 1000, 2000 and 3000 write: * Resolves ibis-project#1000 * Resolves ibis-project#2000 * Resolves ibis-project#3000 If your pull request doesn't resolve any issues, you can delete this section entirely, including the `## Issues closed` section header. --> --------- Co-authored-by: Chloe He <chloe@chloe-mac.lan>
Merging. |
Presentation for the upcoming LinkedIn Meetup on April 24th, 2024.