Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(presentations): presentation for linkedin meetup 2024-04-24 #8983

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 16, 2024

Presentation for the upcoming LinkedIn Meetup on April 24th, 2024.

@cpcloud cpcloud added the docs Documentation related issues or PRs label Apr 16, 2024
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by review -- looks pretty slick!

docs/presentations/linkedin-meetup-2024-04-24.qmd Outdated Show resolved Hide resolved
docs/presentations/linkedin-meetup-2024-04-24.qmd Outdated Show resolved Hide resolved
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Apr 16, 2024
@lostmygithubaccount
Copy link
Member

I don't see why docs-previews wouldn't work, kicking that off

@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 16, 2024
Copy link
Member

@lostmygithubaccount lostmygithubaccount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few initial feedbacks -- main thing is some of the code not executing/showing. this looks awesome! love that we can code-review presentations :) and put them right on the website

docs/presentations/linkedin-meetup-2024-04-24.qmd Outdated Show resolved Hide resolved
docs/presentations/linkedin-meetup-2024-04-24.qmd Outdated Show resolved Hide resolved
docs/presentations/linkedin-meetup-2024-04-24.qmd Outdated Show resolved Hide resolved
docs/presentations/linkedin-meetup-2024-04-24.qmd Outdated Show resolved Hide resolved
docs/presentations/linkedin-meetup-2024-04-24.qmd Outdated Show resolved Hide resolved
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Apr 16, 2024

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Apr 16, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 16, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Apr 16, 2024

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Apr 17, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 17, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Apr 17, 2024

::: {.fragment .fade-in-then-semi-out}
```{python}
#| echo: true
ibis.to_sql(expr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the output here is going off the slide?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's intentional for now.

@cpcloud cpcloud force-pushed the linkedin-talk branch 2 times, most recently from fb0bb46 to 17bace0 Compare April 18, 2024 14:42
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Apr 18, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 18, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Apr 18, 2024

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Apr 22, 2024
@lostmygithubaccount
Copy link
Member

minor issue on not sure on the best fix -- in the list view both presentations show as titled "Ibis" -- could obviously change the titles, but would be nice to somehow include the subtitles here:
image

@cpcloud
Copy link
Member Author

cpcloud commented Apr 22, 2024

I'll poke around for a minute on whether the title on the page can be different from the presentation title, but if not, I'll probably just change the titles or leave it as is.

@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 22, 2024
@cpcloud cpcloud added the docs-preview Add this label to trigger a docs preview label Apr 22, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 22, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Apr 22, 2024

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Apr 23, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 23, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Apr 23, 2024

@cpcloud cpcloud added the docs-preview Add this label to trigger a docs preview label Apr 24, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 24, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Apr 24, 2024

@cpcloud cpcloud added this to the 9.0 milestone Apr 24, 2024
cpcloud and others added 2 commits April 24, 2024 09:41
Co-authored-by: Chloe He <chloe@chloe-mac.lan>
Co-authored-by: Chloe He <chloe@chloe-mac.lan1>
@cpcloud cpcloud force-pushed the linkedin-talk branch 2 times, most recently from cfef8f5 to 4d97b8f Compare April 24, 2024 16:52
@cpcloud cpcloud added the docs-preview Add this label to trigger a docs preview label Apr 24, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 24, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Apr 24, 2024

@cpcloud cpcloud marked this pull request as ready for review April 24, 2024 18:28
@cpcloud cpcloud added the docs-preview Add this label to trigger a docs preview label Apr 24, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Apr 24, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Apr 24, 2024

…n feedback (#26)

<!--
Thanks for taking the time to contribute to Ibis!

Please ensure that your pull request title matches the conventional
commits
specification: https://www.conventionalcommits.org/en/v1.0.0/
-->

## Description of changes

<!--
Write a description of the changes commensurate with the pull request's
scope.

Extremely small changes such as fixing typos do not need a description.
-->

## Issues closed

<!--
Please add Resolves #<issue number> (no angle brackets) if this pull
request
resolves any outstanding issues.

For example, if your pull requests resolves issues 1000, 2000 and 3000
write:

* Resolves ibis-project#1000
* Resolves ibis-project#2000
* Resolves ibis-project#3000

If your pull request doesn't resolve any issues, you can delete this
section
entirely, including the `## Issues closed` section header.
-->

---------

Co-authored-by: Chloe He <chloe@chloe-mac.lan>
@cpcloud
Copy link
Member Author

cpcloud commented Apr 24, 2024

Merging.

@cpcloud cpcloud merged commit 01b521c into ibis-project:main Apr 24, 2024
17 checks passed
@cpcloud cpcloud deleted the linkedin-talk branch April 24, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants