Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove ir.ExprList, ops.ExpressionList and ibis.expr_list() #3000

Closed
kszucs opened this issue Sep 22, 2021 · 3 comments
Closed

refactor: remove ir.ExprList, ops.ExpressionList and ibis.expr_list() #3000

kszucs opened this issue Sep 22, 2021 · 3 comments
Labels
expressions Issues or PRs related to the expression API refactor Issues or PRs related to refactoring the codebase

Comments

@kszucs
Copy link
Member

kszucs commented Sep 22, 2021

My guess is that these constructs are a band aid for accepting multiple expressions instead of a single one - though I need to verify this.

There is another operation called ops.ValueList which does almost the same but creates a ir.ListExpr instead.

According to a github search the publicly exposed api.expr_list() function is not widely used.
@cpcloud cpcloud added the expressions Issues or PRs related to the expression API label Sep 22, 2021
@datapythonista
Copy link
Contributor

Checked that in the past, and I didn't find a use case for those, so happy to see them removed.

This was referenced Sep 22, 2021
Merged
Closed
@cpcloud
Copy link
Member

cpcloud commented Dec 28, 2021

@kszucs Is this done?

@cpcloud cpcloud changed the title Remove ir.ExprList, ops.ExpressionList and ibis.expr_list() refactor: remove ir.ExprList, ops.ExpressionList and ibis.expr_list() Dec 28, 2021
@cpcloud cpcloud added the refactor Issues or PRs related to refactoring the codebase label Dec 28, 2021
@cpcloud
Copy link
Member

cpcloud commented Jan 9, 2022

Done in #3112

@cpcloud cpcloud closed this as completed Jan 9, 2022
lostmygithubaccount pushed a commit that referenced this issue Feb 12, 2024
@deepyaman
docs(blog): add post introducing the Flink backend (#7912)
7bf764f 
<!--
Thanks for taking the time to contribute to Ibis!

Please ensure that your pull request title matches the conventional
commits
specification: https://www.conventionalcommits.org/en/v1.0.0/
-->

## Description of changes

<!--
Write a description of the changes commensurate with the pull request's
scope.

Extremely small changes such as fixing typos do not need a description.
-->

Port https://github.com/claypotai/ibis-flink-example to a
quickstart/blog post.

## Issues closed

<!--
Please add Resolves #<issue number> (no angle brackets) if this pull
request
resolves any outstanding issues.

For example, if your pull requests resolves issues 1000, 2000 and 3000
write:

* Resolves #1000
* Resolves #2000
* Resolves #3000

If your pull request doesn't resolve any issues, you can delete this
section
entirely, including the `## Issues closed` section header.
-->
Resolves #7739
cpcloud pushed a commit to cpcloud/ibis that referenced this issue Apr 24, 2024
@chloeh13q
docs(linkedin-talk): update some streaming slides based on the dry ru…
9029672 
…n feedback (#26)

<!--
Thanks for taking the time to contribute to Ibis!

Please ensure that your pull request title matches the conventional
commits
specification: https://www.conventionalcommits.org/en/v1.0.0/
-->

## Description of changes

<!--
Write a description of the changes commensurate with the pull request's
scope.

Extremely small changes such as fixing typos do not need a description.
-->

## Issues closed

<!--
Please add Resolves #<issue number> (no angle brackets) if this pull
request
resolves any outstanding issues.

For example, if your pull requests resolves issues 1000, 2000 and 3000
write:

* Resolves ibis-project#1000
* Resolves ibis-project#2000
* Resolves ibis-project#3000

If your pull request doesn't resolve any issues, you can delete this
section
entirely, including the `## Issues closed` section header.
-->

---------

Co-authored-by: Chloe He <chloe@chloe-mac.lan>
lostmygithubaccount pushed a commit that referenced this issue Jul 12, 2024
@randyzwitch
docs: add Shiny (for Python) to "works well with" section (#9558)
8862979 
<!--
Thanks for taking the time to contribute to Ibis!

Please ensure that your pull request title matches the conventional
commits
specification: https://www.conventionalcommits.org/en/v1.0.0/
-->

## Description of changes
Ibis works great within Shiny for Python as well, not just Quarto. Add
link to Shiny to the docs.
<!--
Write a description of the changes commensurate with the pull request's
scope.

Extremely small changes such as fixing typos do not need a description.
-->

## Issues closed

<!--
Please add Resolves #<issue number> (no angle brackets) if this pull
request
resolves any outstanding issues.

For example, if your pull requests resolves issues 1000, 2000 and 3000
write:

* Resolves #1000
* Resolves #2000
* Resolves #3000

If your pull request doesn't resolve any issues, you can delete this
section
entirely, including the `## Issues closed` section header.
-->
cpcloud pushed a commit that referenced this issue Sep 2, 2024
@rz-vastdata
fix(strings): correct a typo in startswith docstring (#9994)
f98aec5 
<!--
Thanks for taking the time to contribute to Ibis!

Please ensure that your pull request title matches the conventional
commits
specification: https://www.conventionalcommits.org/en/v1.0.0/
-->

## Description of changes

<!--
Write a description of the changes commensurate with the pull request's
scope.

Extremely small changes such as fixing typos do not need a description.
-->

## Issues closed

<!--
Please add Resolves #<issue number> (no angle brackets) if this pull
request
resolves any outstanding issues.

For example, if your pull requests resolves issues 1000, 2000 and 3000
write:

* Resolves #1000
* Resolves #2000
* Resolves #3000

If your pull request doesn't resolve any issues, you can delete this
section
entirely, including the `## Issues closed` section header.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expressions Issues or PRs related to the expression API refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(ir): Remove ir.ExprList, ops.ExpressionList and ibis.expr_list() [WIP] kszucs/ibis
3 participants
@cpcloud @kszucs @datapythonista