Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(blog): add post introducing the Flink backend #7912

Merged
merged 16 commits into from
Feb 12, 2024

Conversation

deepyaman
Copy link
Contributor

@deepyaman deepyaman commented Jan 5, 2024

Description of changes

Port https://github.com/claypotai/ibis-flink-example to a quickstart/blog post.

Issues closed

Resolves #7739

@deepyaman deepyaman marked this pull request as ready for review January 6, 2024 02:00
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jan 6, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jan 6, 2024
@deepyaman deepyaman force-pushed the patch-5 branch 3 times, most recently from e179d53 to a25d1aa Compare January 6, 2024 06:45
pyproject.toml Outdated Show resolved Hide resolved
@deepyaman deepyaman force-pushed the patch-5 branch 3 times, most recently from 0994dd9 to 548d5bc Compare January 9, 2024 17:33
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stylistic requests; content-wise this looks good!

docs/posts/flink-quickstart/index.qmd Outdated Show resolved Hide resolved
docs/posts/flink-quickstart/index.qmd Outdated Show resolved Hide resolved
docs/posts/flink-quickstart/index.qmd Outdated Show resolved Hide resolved
docs/posts/flink-quickstart/index.qmd Outdated Show resolved Hide resolved
docs/posts/flink-quickstart/index.qmd Outdated Show resolved Hide resolved
@deepyaman deepyaman force-pushed the patch-5 branch 2 times, most recently from d2dc0ad to c8edc68 Compare January 9, 2024 19:20
@deepyaman deepyaman requested a review from cpcloud January 9, 2024 19:32
cpcloud
cpcloud previously requested changes Jan 9, 2024
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change! After that, I will approve and merge!

docs/posts/flink-quickstart/index.qmd Outdated Show resolved Hide resolved
@cpcloud
Copy link
Member

cpcloud commented Jan 9, 2024

@deepyaman Can you target against main? The 8.x.x branches changes have been merged into main, since the next release we're targeting is 8.0.0.

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jan 9, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jan 9, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jan 9, 2024

docs/_tabsets/install.qmd Outdated Show resolved Hide resolved

## Introduction

Ibis 8.0.0 marks the official release of the Apache Flink backend for Ibis.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd emphasizing first streaming backend + why this is important

Ibis v8 marks the official release of the first streaming backend for Ibis: the Apache Flink backend. Ibis users can now do data manipulation across both streaming and batch using the same interface. (something like that)

Copy link
Contributor

@chiphuyen chiphuyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the post is more of an installation guide rather than an introduction post. do you want to keep it like this or want to add more meats like potential use cases and why this is a big deal (like why the world sucks without this feature?)

@deepyaman
Copy link
Contributor Author

looks like the post is more of an installation guide rather than an introduction post. do you want to keep it like this or want to add more meats like potential use cases and why this is a big deal (like why the world sucks without this feature?)

It was intended mostly as a "quickstart with the Flink backend."

Would anything around potential use cases be Flink-specific? Would it make more sense to include that in the Flink/RisingWave/general Ibis support for streaming announcement, and leave this more as a quickstart?

@chiphuyen
Copy link
Contributor

looks like the post is more of an installation guide rather than an introduction post. do you want to keep it like this or want to add more meats like potential use cases and why this is a big deal (like why the world sucks without this feature?)

It was intended mostly as a "quickstart with the Flink backend."

Would anything around potential use cases be Flink-specific? Would it make more sense to include that in the Flink/RisingWave/general Ibis support for streaming announcement, and leave this more as a quickstart?

i see. maybe rename the title to reflect that this is a quickstart guide?

@deepyaman
Copy link
Contributor Author

looks like the post is more of an installation guide rather than an introduction post. do you want to keep it like this or want to add more meats like potential use cases and why this is a big deal (like why the world sucks without this feature?)

It was intended mostly as a "quickstart with the Flink backend."

Would anything around potential use cases be Flink-specific? Would it make more sense to include that in the Flink/RisingWave/general Ibis support for streaming announcement, and leave this more as a quickstart?

@chiphuyen @lostmygithubaccount would some of this feedback make more sense to address in #8200? I could imagine, the flow of a reader be:

  1. Oh, cool, Ibis v8 includes a bunch of new features, including streaming support (Cody's post)
  2. I want to try one of them, the Flink backend (this post)

@lostmygithubaccount
Copy link
Member

I have some of the language in here: #8200

but would be worth having streaming expert expand on that either there or a separate post

@chiphuyen
Copy link
Contributor

I have some of the language in here: #8200

but would be worth having streaming expert expand on that either there or a separate post

oh i see. cody is ahead of our time

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Feb 2, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Feb 2, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Feb 3, 2024

Copy link
Member

@lostmygithubaccount lostmygithubaccount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments -- @deepyaman can you address these soon and update the execution file? and ideally remove the old one if you are changing the directory path?

docs/posts/flink-quickstart/index.qmd Outdated Show resolved Hide resolved
docs/posts/flink-quickstart/index.qmd Outdated Show resolved Hide resolved
docs/posts/flink-quickstart/index.qmd Outdated Show resolved Hide resolved
docs/posts/flink-quickstart/index.qmd Outdated Show resolved Hide resolved
Copy link
Member

@lostmygithubaccount lostmygithubaccount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@lostmygithubaccount lostmygithubaccount merged commit 7bf764f into ibis-project:main Feb 12, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flink Issues or PRs related to Flink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(flink): add a basic "getting started" example
6 participants