-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(blog): kaggle competition using IbisML #9505
docs(blog): kaggle competition using IbisML #9505
Conversation
@jitingxu1 is the freeze in sync for the latest commit? it looks like it's trying to execute the blog post instead of using a cached version (and then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just took a quick pass, some small formatting nits mostly.
I think it might be good to run black
or ruff
on all of the python code blocks for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Took a pass through, but most of the changes requested are rather small. Maybe two main points:
- Some takeaways could be good.
- I don't know if there's much to be done about it, but I personally found it a bit long, especially given there are so many callouts. But that may be just my personal opinion.
@jitingxu1 looks like there are couple comments here that need to be addressed. |
@lostmygithubaccount ping for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove the black bars from duckdb's progress bar? see https://github.com/ibis-project/ibis/blob/main/docs/posts/1brc/index.qmd#L196-L200 for an example
docs/posts/ibisml/index.qmd
Outdated
--- | ||
title: "Using IbisML and DuckDB for a Kaggle competition: credit risk model stability" | ||
author: "Jiting Xu" | ||
date: "2024-08-15" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update to 2024-08-21? let's publish and promote tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for writing this! a few more smaller nits
@jitingxu1 do you now have the option to merge this? |
I think I cannot.
|
@lostmygithubaccount you're an Ibis committer, so you can; @jitingxu1 is not. |
Description of changes
kaggle competition using IbisML
If we have time, may add some feature engineering using Ibis
Issues closed