Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(blog): kaggle competition using IbisML #9505

Merged

Conversation

jitingxu1
Copy link
Contributor

@jitingxu1 jitingxu1 commented Jul 2, 2024

Description of changes

kaggle competition using IbisML

If we have time, may add some feature engineering using Ibis

Issues closed

@jitingxu1 jitingxu1 added the docs-preview Add this label to trigger a docs preview label Jul 3, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 3, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jul 3, 2024

@jitingxu1 jitingxu1 added the blog Posts for the Ibis blog. label Jul 9, 2024
@jitingxu1 jitingxu1 requested a review from jcrist July 9, 2024 19:06
@deepyaman deepyaman added the docs-preview Add this label to trigger a docs preview label Jul 9, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 9, 2024
@lostmygithubaccount
Copy link
Member

@jitingxu1 is the freeze in sync for the latest commit? it looks like it's trying to execute the blog post instead of using a cached version (and then ibis_ml isn't installed in the environment)

@lostmygithubaccount lostmygithubaccount added docs-preview Add this label to trigger a docs preview docs Documentation related issues or PRs labels Jul 9, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 9, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jul 9, 2024

@ncclementi ncclementi added the docs-preview Add this label to trigger a docs preview label Jul 14, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 14, 2024
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just took a quick pass, some small formatting nits mostly.

I think it might be good to run black or ruff on all of the python code blocks for consistency.

docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
@jitingxu1 jitingxu1 added the docs-preview Add this label to trigger a docs preview label Jul 25, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jul 25, 2024
Copy link
Contributor

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Took a pass through, but most of the changes requested are rather small. Maybe two main points:

  • Some takeaways could be good.
  • I don't know if there's much to be done about it, but I personally found it a bit long, especially given there are so many callouts. But that may be just my personal opinion.

docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Show resolved Hide resolved
@ncclementi
Copy link
Contributor

@jitingxu1 looks like there are couple comments here that need to be addressed.

@jitingxu1
Copy link
Contributor Author

@lostmygithubaccount ping for review

@jitingxu1 jitingxu1 added the docs-preview Add this label to trigger a docs preview label Aug 16, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Aug 16, 2024
Copy link
Member

@lostmygithubaccount lostmygithubaccount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the black bars from duckdb's progress bar? see https://github.com/ibis-project/ibis/blob/main/docs/posts/1brc/index.qmd#L196-L200 for an example

---
title: "Using IbisML and DuckDB for a Kaggle competition: credit risk model stability"
author: "Jiting Xu"
date: "2024-08-15"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update to 2024-08-21? let's publish and promote tomorrow

docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Aug 21, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Aug 21, 2024
Copy link
Member

@lostmygithubaccount lostmygithubaccount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for writing this! a few more smaller nits

docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibisml/index.qmd Outdated Show resolved Hide resolved
@lostmygithubaccount
Copy link
Member

@jitingxu1 do you now have the option to merge this?

@jitingxu1
Copy link
Contributor Author

@jitingxu1 do you now have the option to merge this?

I think I cannot.

You’re not authorized to merge this pull request.

@deepyaman
Copy link
Contributor

@jitingxu1 do you now have the option to merge this?

@lostmygithubaccount you're an Ibis committer, so you can; @jitingxu1 is not.

@lostmygithubaccount lostmygithubaccount merged commit 7320c18 into ibis-project:main Aug 22, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog Posts for the Ibis blog. docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants