feat(timestamps): add support for timestamp/date +/- intervals for additional backends #9799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
feature
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
cpcloud
changed the title
cpcloud
commented
Aug 8, 2024
| month = alltypes.date_string_col[:2] | ||
| day = alltypes.date_string_col[3:5] | ||
| year = alltypes.date_string_col[6:8] | ||
| date_col = ("20" + year + "-" + month + "-" + day).cast("date") |
There was a problem hiding this comment.
More backends implement the primitives here than the previous code, which used arrays.
…and clean up use of `sge.Var`
… month, week, and day granularity
…n integer to an interval
cpcloud
commented
Aug 8, 2024
| @@ -404,6 +400,8 @@ def visit_Cast(self, op, *, arg, to): | |||
| return arg | |||
| elif from_.is_integer() and to.is_timestamp(): | |||
| return self.f.dateadd(self.v.s, arg, "1970-01-01 00:00:00") | |||
| elif from_.is_integer() and to.is_interval(): | |||
| return sge.Interval(this=arg, unit=self.v[to.unit.singular]) | |||
There was a problem hiding this comment.
Since this is such a common implementation I'm going to try and encode the logic in the base implementation of visit_Cast
gforsyth
approved these changes
Aug 8, 2024
|
I'll do it in a follow-up now that you mention it. |
|
Lemme run the clouds |
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #9794, I decided to investigate whether we can do a bit better on date/timestamp +/- interval-style operations.
Many backends support adding and subtracting intervals from dates and timestamps, but do not support intervals as a first-class type, and we can allow that functionality to work.
This PR adds support for those operations to mssql and oracle and consolidates some existing implementation details around the
IntervalFromIntegeroperation.