refactor(intervals): conslidate interval conversion under _make_interval base compiler implementation

[cpcloud]

Follow-up to #9799 to consolidate some repetitive interval-handling code.

[gforsyth]

Exasol is an XPASS -- Postgres and Risingwave are throwing syntax errors -- I wouldn't think that op.arg and arg are different, but maybe they are?

[cpcloud]

Yep, just working through sqlite now, it's quite ... unique.

[cpcloud]

Hell yeah, it's just a sea of unfailure!

[cpcloud]

Ah, for postgres we're not calling visit_Cast ... fixing that now.

[cpcloud]

Gonna do a rebase merge on this one so the sqlite feat gets picked up in the release notes.

[gforsyth]

nice!

[cpcloud]

Looks like I might be hitting a sqlite version issue.

[cpcloud]

sad

[cpcloud]

I love that if you pass a bogus argument to sqlite, it returns NULL. <-- Sarcasm

[cpcloud]

I think I might just raise an exception for sqlite < 3.46. Otherwise we're looking at implementing this function

https://github.com/sqlite/sqlite/blob/a0789fcc4917af0cdf343c073152045a990a7313/src/date.c#L299

[cpcloud]

yyyyy

[cpcloud]

GHA is running on 3.40.x 😢

[cpcloud]

At this point I'm ready to declare versioning bankruptcy and xfail with strict=False since we're running these tests on the nix jobs which have the latest version of sqlite.

[cpcloud]

Oh wait I forgot we allow condition in backend markers. Trying that now.

[cpcloud]

Clouds look good:

…/ibis on  consolidate-interval-implementations is 📦 v9.3.0 via 🐍 v3.10.14 via ❄️   impure (ibis-3.10.14-env)
❯ pytest -m snowflake -n 8 --dist loadgroup --snapshot-update -q && pytest -m bigquery -n auto --dist loadgroup --snapshot-update -q
bringing up nodes...
................................................xx.........................................x................................................................................x......... [  9%]
.........x......................x........s................x.....x.x..................x................x.....x..............x...xx..x.....x......xxx.x..x.....................x..xxx.xx [ 19%]
.......x.......x.s..............x.x.xx.xxx.x..xxx.x.xxx..x.x..xx.x.x...x..xx..xx..x.x.....x.xxxxxx.x..xx..x...xx.x..x.x.xx..x..x..xx.xx.xxx.x.xxxx.x.xx.....x.....xx..x............... [ 29%]
...x.x.....x......x...........................x.................xx.............x.....x...........xx..........x.............................x..xx..................x..........xx....... [ 39%]
...........x.......x..............x....................................................x....x..........x.x............................................................................ [ 49%]
........................................xx.....x...........x.x......................xx......x..x...........x....x.........x...x.............x...........x.x....x.......x.............. [ 59%]
....x...x..x.x............x......x.x.x.x..x.x..x..xxxxx.xxxxx.....xx..x...x................x.....................s......................s..s.........................xx.xx.xxxx.x.x.xx [ 68%]
....x.....x...........x........x..............................x.............x......x...........x.x...x...x....x......x...................x..........x..........................x...... [ 78%]
...xx...x......x..............x..........x.x.........xx......................x......................x..........x.x.................x.x...x....x.x...x...s.................x........... [ 88%]
.x........s.....................................................................s..................................................................................................... [ 98%]
......s....s..................                                                                                                                                                         [100%]
1624 passed, 10 skipped, 216 xfailed in 210.48s (0:03:30)
bringing up nodes...
.....................................................................................................................................................................x...sssssssssssss [  8%]
ssssssss...xx.................sssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssx....x.........x...........x.xx...........ss.......xx.........x..xx........x......x...x.. [ 17%]
..x.s.................x.x......x.xxx....x..xx..xx.x.xxxxxxxxxxxxxxxxxxxx.xx.xx.xxxxxxxx.xxxxxxxxx.xx.xxxxxxx.xxxxxxxxxxxxx.xxxxxxxxxxxxxxxx.xxxxxxxxx.xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx [ 26%]
xxxxxxxxx.xxx..x....x......x.xx...x.....s...........x...x.............x..x.............................x..x............xxx...................................x.x....x..x........xx.... [ 35%]
.xxx.x.....x..x.xx..........xx..xx.x....x..x.....x.x....x.........x...x........x..x....xx....x..........x.....x.x..x.xx.......x..xx....xx.....x.................x......x...x...x...... [ 43%]
x...x....xx..x.xxx......x...........x..xxx.....x....s..................x..........x...................x.....X.x...x.x...xx.xx.xx..xXx.....x.....x.x.x..........x...........x.....x.... [ 52%]
.x.....x.x.x.................x...x..........x.....x.x..x.x.X.x.......XxX..x...x..........xx..............x.....................x.x......x.x....x...xx...x....x....x..xx...........x... [ 61%]
x.........x...................................x............x....x......x..........x..x.......s.......x.............x............s..................................................... [ 70%]
......x..........xs...................x......x......x...x.....x.........x........x.x..x..x.x......x..x.................x......xx...x.....................x....x...........x....xxxxxxx [ 79%]
xx.....x............xx.x....x............................................................................x.........................................................x......x........... [ 87%]
......................................................................................................................x......x..........................................x............. [ 96%]
.....................................................................                                                                                                                                              [100%]
1632 passed, 92 skipped, 342 xfailed, 5 xpassed in 309.60s (0:05:09)