Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(duckdb): free memtables based on operation lifetime #10042

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 6, 2024

Closes #10041.

@cpcloud cpcloud added bug Incorrect behavior inside of ibis performance Issues related to ibis's performance duckdb The DuckDB backend labels Sep 6, 2024
@cpcloud cpcloud requested a review from jcrist September 6, 2024 13:45
@cpcloud cpcloud changed the title duckdb free memtables early fix(duckdb): free memtables based on operation lifetime Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud
Copy link
Member Author

cpcloud commented Sep 6, 2024

@liudvikasakelis Would you mind giving this a try?

Copy link
Contributor

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpcloud
Copy link
Member Author

cpcloud commented Sep 6, 2024

What hell hath I wrought?

@cpcloud cpcloud enabled auto-merge (squash) September 9, 2024 13:52
@cpcloud cpcloud merged commit a121ab3 into ibis-project:main Sep 9, 2024
81 checks passed
@cpcloud cpcloud deleted the duckdb-free-memtables-early branch September 9, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis duckdb The DuckDB backend performance Issues related to ibis's performance 🐰 🕳️ Rabbit hole. Enter at your own risk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ibis.memtable leaks memory with default (duckdb) backend
3 participants