Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(blog): ibis, duckdb and lonboard for overture maps #10143
docs(blog): ibis, duckdb and lonboard for overture maps #10143
Changes from 2 commits
de4c7eb
c9a749b
a943dac
e941a3b
f9b905b
f64a7c6
f329636
bd06b3f
d8b2510
9050b5c
bcee24f
4ec6cac
abf0863
521958b
0ae44aa
2b22433
20e0bb7
11fb399
c3a7481
39ebbb5
a507754
c1fa0b5
d0e72e9
f15b1e6
6b7ceb8
bbf4294
5a6f29f
a88f384
21877db
d203eb4
21a858c
6c07598
a22527f
e3a02b8
d2a9060
198b886
87ee637
207f334
9f9f953
d58c619
6d566d1
b0603a2
83606f5
e0e79ae
becc6ea
3df1e32
79c246e
d8debde
d49767b
ba36c77
019aed4
4d8a3b3
01bfb6f
3d7d530
1dc97a4
b54f528
dc16506
2b95c18
317b055
25ef934
7055525
3ad6e6d
f910cef
3a83aa4
75dac5c
bde00c3
14af3f4
6aa7c44
e0d3dde
64e97c9
147f3f1
59ae216
c3a7b43
c33c263
9402725
c5ccb99
1ae4bd1
2aa51ae
f34106f
3e9396c
12023e6
e5c11af
fcd7564
7ca2fdc
7c6a176
2cb5771
fc626cc
4957854
19c3845
a563504
cf39ea0
21d748c
7cdd2ee
b0060e4
0284736
39362cd
13f9291
cd9ee1b
b7135e7
3c223de
8191a05
7689b6d
5d0e807
67ee2b4
d16d0c7
8f66695
92f1a89
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd start with a sentence intro about what Overture Maps is. Like
(not sure that's the best one-liner description of what Overture Maps is, any zingers @jwass ?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for this blog post, but it would also be nice if there was some way to put this into a
read_geoparquet
query so that the user doesn't have to reach into these.bbox.xmin
columns themselves.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow, is this like a feature request for Ibis to implement a GeoParquet reader for Overture Maps?
DuckDB does the same thing see example https://docs.overturemaps.org/getting-data/duckdb/ , and for the record these filters get push down so you only download what's needed instead of downloading and then filtering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also do this from Python in case you wanted to avoid reaching for the command line, but this is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just learned that the DuckDB bug fix will go out next week (see Max's comment below), so I'll rewrite this part to read download the data that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I'd suggest using standard black/ruff code formatting for all Python code blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I'll fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is more effort for the GPU to render lines than to render points, but a line isn't rendered as a collection of points.
It might be clearer to say
7 million coordinates
rather than points.