-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api): remove schema #10149
refactor(api): remove schema #10149
Conversation
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
I'm not sure I understand how the |
If something is xpassing, generally the approach is to delete the marker that's causing the problem. |
the signature check is to enforce (eventually) that all the backends call all positional arguments the same thing, etc (that's why currently, almost all of them are xfailed) When you removed the schema kwarg, it made some of the backend-specific table methods match the method definition from BaseBackend. removing entries from those xfails is a good thing, though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, i think we lost one bit of testing that we shouldn't have.
Co-authored-by: Gil Forsyth <gforsyth@users.noreply.github.com>
f0bc394
to
a1f7f50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good riddance!
I've got to check to make sure the commit message is going to be formatted correctly, then we can merge |
BREAKING CHANGE: Removed hierarchical usage of schema. Ibis uses the following naming conventions: - schema: a mapping of column names to datatypes - database: a collection of tables - catalog: a collection of databases --------- Co-authored-by: Gil Forsyth <gforsyth@users.noreply.github.com> Co-authored-by: Gil Forsyth <gil@forsyth.dev>
BREAKING CHANGE: Removed hierarchical usage of schema.
Ibis uses the following naming conventions: