Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(bigquery): avoid race condition in create table by using a dataset scoped to a specific user and python version #10159

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 18, 2024

We do this for other bigquery tests, to avoid failures like this: https://github.com/ibis-project/ibis/actions/runs/10921405259/job/30313419648.

… scoped to a specific user and python version
@cpcloud cpcloud added this to the 10.0 milestone Sep 18, 2024
@cpcloud cpcloud added ci Continuous Integration issues or PRs bigquery The BigQuery backend labels Sep 18, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Sep 18, 2024

I'll poke around the bigquery test suite and see if there are other cases where we aren't scoping to a specific user/dataset combo.

@cpcloud
Copy link
Member Author

cpcloud commented Sep 18, 2024

It looks like everywhere else we're using con, which is by construction scoped to a user/database
or we're making a new backend instance with the dataset_id fixture which is construction that way as well.

@cpcloud
Copy link
Member Author

cpcloud commented Sep 18, 2024

BigQuery tests passing locally:

…/ibis on  fix-bigquery-test is 📦 v9.5.0 via 🐍 v3.12.5 via ❄️   impure (ibis-3.12.5-env)
❯ pytest -m bigquery -n auto --dist loadgroup --snapshot-update -q
bringing up nodes...
......xx....x..x....xxx.xsssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss..................xxsssssssssssssssssssss..........xx..xx.x....... [  8%]
....xx............x...x....xx......x......x..........x.x....x.x......xx.....x.x.x.........x..............x...xx.....x......x.......x...xx.x..........................xx.................x...xx [ 17%]
.x................x.......x.x.x.........x.x......x..x.....x......x.......x.........x.....x...x..x...x.x.x.............x...x.x....x..........x.........x.....................x...xx............ [ 25%]
..x.......x.x..............x.....x...x..............x.x.....xxx.x..x...xxxxx.x.xx.xxxx.xxxxxxxxxxx.x.xxxxxxxxxxxxxxxxxx.xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx.xxxxxxxxxxxxxxxxxxxxx.xxxxxxxxxxxx [ 34%]
.x.x.x.xx..xx..x..x....xx.x......xx.x.x......x......x....x............x.....x.................xx......x.....xxx...x...x..x.x.....xx..x.x....x..x...x..xx.x...xxx..x......x.....x.x..........x. [ 43%]
......................x..............x....................x...........x.............................x.........x...x......x.xXx.x........x.....xxx......x..xxxx.....x.....Xxx....x.x.....x..x.. [ 51%]
........x...x.x.....x..x..x..xx.x.........X...x..x....xxx..........x..........x......X..........xx.....................s.................x........xxxxxxxxx......x..........x.x..x.xxx.x...x.. [ 60%]
xxx.xx.x...xx.xxx......x..........x...x.x.x.........................................................x...................................x......................x...........................x.. [ 68%]
................................................................s.s.................s........x.........s......x............x........x.xX.x..xx..............s............s.....s...x.......... [ 77%]
x..x.............x.......................x........................x.........x...................x............................................................................................. [ 86%]
x................................................................................................s......s.....................s...x...............s...x....................................... [ 94%]
.....................................................................................................................                                                                          [100%]
1720 passed, 132 skipped, 350 xfailed, 5 xpassed in 382.80s (0:06:22)

@cpcloud cpcloud merged commit 966c5e8 into ibis-project:main Sep 18, 2024
78 checks passed
@cpcloud cpcloud deleted the fix-bigquery-test branch September 18, 2024 13:39
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery The BigQuery backend ci Continuous Integration issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant