-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigquery): non-nullable schema support for embedded fields in struct #10189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
Issues or PRs related to tests
bigquery
The BigQuery backend
labels
Sep 20, 2024
cpcloud
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BigQuery tests look good:
…/ibis on ssabdb/main:main is 📦 v9.5.0 via 🐍 v3.12.5 via ❄️ impure (ibis-3.12.5-env)
❯ pytest -m bigquery -n auto --dist loadgroup --snapshot-update -q
bringing up nodes...
..................sssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss...sssssssssssssssssssss.....x................s........x............................x.............xx...x.....x...x..xxxx..xx.xxxxx...xx..x.xx.xxxx..x.x.xxxxx..x.xxxxxx.xx.xxxxxxxxxx.xxxxx.xxxxxxxx..xx.xxxxxxxxxx.xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx.xx.x.xx.xxxxxxxxxxxxxxxxxxxxx [ 17%]
xxxxxxxxx..xxxxxx...x.x.x.......x......x.......xx.....x...............x............x.......x.....................................................x.............x............x...............x......x...x......xxx.....xx.........x......x...x....xxx..X.x....X..x..x.x.x.....x...x....X..x...xx.x.....xxx.xx........xX.x.x.xx.............x.xxx......x........x.x....x...x........x.xxx.x..x..x.xx..x [ 35%]
..x.....x...xx...x......x....x.................................x........................x............................x.............................................................x..x....x...........x........xxx...x...................x......x.....................x........xx..x.....x.......x..x....x...x....x.....................................x.......x........x................x.......x. [ 52%]
..............x..................x..................x..xx...x.....x...xxx........xx........x.........x.x.x..xx...............x...........x..........................xxxxx...xxx.xxx...x.....x...x..xx.x.....x.........s...x.........xs.....x......s.....x.................................x...........x.......x...xx.....xx.x.....x..x......x........xx..x.x.x.....x....xxx.x.....xx..........xx.x... [ 70%]
......xxx...........x...xxx.......x...xx.................................xx.......x.............x.......x......x.x......x.......x...Xs.x......s.xsx.xs.................................................................................................................................................................................x............................................................. [ 88%]
...........x..............s..........s....s...........x..........................................................x.....x..................................................................................................................s...............x.......... [100%]
1719 passed, 132 skipped, 350 xfailed, 5 xpassed in 362.04s (0:06:02)
Thanks for the PR! |
Thanks for the fast merge! |
ncclementi
pushed a commit
to ncclementi/ibis
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bigquery supports embedded non-nullable checks inside bigquery schemas, allowing any non-nullable fields in the schema to persist down into bigquery.
Description of changes
Override _from_ibis_Struct for bigquery to allow the adding of a non-nullable field constraint
Issues closed
Resolves #10188, at least for bigquery. There might be opportunities to implement this change in other backends as well.