Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backends): convert scalars to non-numpy python objects #10233

Merged

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 26, 2024

This PR converts scalar numpy objects into their non-numpy Python equivalents for consistent scalar return types for all backends.

BREAKING CHANGE: execute now returns non-numpy objects for scalar values.

@cpcloud cpcloud added this to the 10.0 milestone Sep 26, 2024
@github-actions github-actions bot added the tests Issues or PRs related to tests label Sep 26, 2024
@cpcloud cpcloud force-pushed the convert-scalar-to-non-numpy-objects branch from 755dbd8 to f16174f Compare September 26, 2024 10:59
@cpcloud cpcloud force-pushed the convert-scalar-to-non-numpy-objects branch from f16174f to d2c10a9 Compare September 26, 2024 11:00
@cpcloud cpcloud merged commit df08d5e into ibis-project:main Sep 27, 2024
78 checks passed
@cpcloud cpcloud deleted the convert-scalar-to-non-numpy-objects branch September 27, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant