Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mysql): handle database names that must be quoted in list_tables #10466

Merged
merged 3 commits into from
Nov 10, 2024
Merged

fix(mysql): handle database names that must be quoted in list_tables #10466

merged 3 commits into from
Nov 10, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Nov 10, 2024 •
edited
Loading

  • chore: remove some uses of sg.exp for sge
  • test(mysql): use a dash in the database name
  • fix(mysql): handle database names that must be quoted in list_tables

Closes #10459.

@cpcloud cpcloud added this to the 10.0 milestone Nov 10, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis tests Issues or PRs related to tests mysql The MySQL backend labels Nov 10, 2024
@github-actions github-actions bot added the sql Backends that generate SQL label Nov 10, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Nov 10, 2024

I can alternatively just create a one-off database for testing the list_tables call.

@cpcloud
Copy link
Member Author

cpcloud commented Nov 10, 2024

The only downside there is that we wouldn't be verifying the whole test suite against a funkier name.

@gforsyth
Copy link
Member

Nah, I think this is good. Same idea as testing against a case-sensitive collation in mssql -- make everything work in the harder scenario

gforsyth
gforsyth approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cpcloud cpcloud enabled auto-merge (squash) November 10, 2024 15:41
@cpcloud cpcloud merged commit 23c0e81 into ibis-project:main Nov 10, 2024
76 checks passed
@cpcloud cpcloud deleted the fix-mysql-quoting branch November 10, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis mysql The MySQL backend sql Backends that generate SQL tests Issues or PRs related to tests
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

bug: cannot list tables from database containing special characters
2 participants
@cpcloud @gforsyth