Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: test(fixtures): ensure that most connections are cleaned up when the session ends (#10693) #10717

Merged
merged 1 commit into from
Jan 24, 2025
Merged

revert: test(fixtures): ensure that most connections are cleaned up when the session ends (#10693) #10717

merged 1 commit into from
Jan 24, 2025

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jan 24, 2025

This was apparently more trouble than it was worth.

@cpcloud cpcloud added this to the 10.0 milestone Jan 24, 2025
@cpcloud cpcloud added the tests Issues or PRs related to tests label Jan 24, 2025
@github-actions github-actions bot added postgres The PostgreSQL backend sqlite The SQLite backend clickhouse The ClickHouse backend mysql The MySQL backend pyspark The Apache PySpark backend datafusion The Apache DataFusion backend duckdb The DuckDB backend polars The polars backend snowflake The Snowflake backend mssql The Microsoft SQL Server backend trino The Trino backend oracle The Oracle backend risingwave The RisingWave backend labels Jan 24, 2025
@cpcloud cpcloud merged commit 470e6fd into ibis-project:main Jan 24, 2025
86 of 88 checks passed
@cpcloud cpcloud deleted the revert-test-cleanup branch January 24, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
clickhouse The ClickHouse backend datafusion The Apache DataFusion backend duckdb The DuckDB backend mssql The Microsoft SQL Server backend mysql The MySQL backend oracle The Oracle backend polars The polars backend postgres The PostgreSQL backend pyspark The Apache PySpark backend risingwave The RisingWave backend snowflake The Snowflake backend sqlite The SQLite backend tests Issues or PRs related to tests trino The Trino backend
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@cpcloud