Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Implementing rowid #2345

Merged
merged 7 commits into from
Sep 1, 2020
Merged

ENH: Implementing rowid #2345

merged 7 commits into from
Sep 1, 2020

Conversation

datapythonista
Copy link
Contributor

Closes #1462
Supersedes #2251

Implementing rowid for backends that support it. Based on the implementation in #2251, but I think this implementation is simpler, and also tried to make the docs more useful for users.

@datapythonista datapythonista added feature Features or general enhancements sqlite The SQLite backend backends - omnisci labels Aug 27, 2020
@datapythonista
Copy link
Contributor Author

@jreback I'm reimplementing the rowid feature started in #2251 here. Do you mind having a look? I think this implementation should be simpler.

@datapythonista
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks.

"""
An autonumeric representing the row number of the results.

It can be 0 or 1 indexed depending on the backend. Check the backend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really?

@jreback jreback added this to the Next Feature Release milestone Sep 1, 2020
@jreback jreback merged commit 10d4030 into ibis-project:master Sep 1, 2020
@jreback
Copy link
Contributor

jreback commented Sep 1, 2020

thanks @datapythonista

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements sqlite The SQLite backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RowId operation
2 participants