Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): Add ibis.asc expression #3589

Merged
merged 1 commit into from
Mar 11, 2022
Merged

feat(api): Add ibis.asc expression #3589

merged 1 commit into from
Mar 11, 2022

Conversation

hussainsultan
Copy link
Contributor

Fixes #1454

@pep8speaks
Copy link

pep8speaks commented Mar 11, 2022 •
edited
Loading

Hello @hussainsultan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-03-11 17:38:12 UTC

@cpcloud cpcloud added feature Features or general enhancements expressions Issues or PRs related to the expression API labels Mar 11, 2022
@cpcloud cpcloud added this to the 3.0.0 milestone Mar 11, 2022
cpcloud
cpcloud approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thank you.

@cpcloud cpcloud merged commit efe177e into ibis-project:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
expressions Issues or PRs related to the expression API feature Features or general enhancements
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

feat: expose APIs for constructing SortExprs using asc/desc functions and methods
3 participants
@hussainsultan @pep8speaks @cpcloud