-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add agg
alias for aggregate
#4765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks like you already merged this and I understand that Beyond t.rollup
t.select
t.mutate
t.filter It is a slippery slope boxing yourself into trying to keep names the same length, of course. Another shortened verb that has some precedence is I mostly just geek out about this stuff. Not proposing that you change your mind on any of these names. |
Personally I prefer explicit full English words in APIs. I also like the symmetry between Also, I tend to dislike aliases because then it breaks the community in term of programming style and the extra alternatives are confusing for newcomers. |
The only issue with We have (the rather ancient!) #550 open for this functionality :)
I definitely appreciate this, but, yeah it seems like it'll be a hard corner to get out of if we go down this route.
Not opposed to |
I sympathize with this for sure: when writing pipelines being explicit made things easier to understand. There's probably an analogy (and a similar tension with iteration speed and convenience) with CI and production shell script arguments here.
There's always the possibility of
Yeah, I understand this too. The way we've currently been thinking about this is to pick a primary API and remove all references to the secondary API in documentation and tests but not actually remove the secondary API to avoid breaking existing code that uses it. Optionally we can add a deprecation warning if we actually do intend to remove it at some point. |
Please no! |
Add an
agg
alias foraggregate
. I am really tired of typing out the entire word.