Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev-deps): add syrupy #4985

Closed
wants to merge 1 commit into from
Closed

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Dec 9, 2022

Moves our snapshot assertions to use syrupy, which dramatically cuts down on the number of files, is more convenient to use and does not have issues with case-insensitive file systems. Fixes #4983.

@cpcloud cpcloud added this to the 4.0.0 milestone Dec 9, 2022
@cpcloud cpcloud added tests Issues or PRs related to tests developer-tools Tools related to ibis development dependencies Issues or PRs related to dependencies labels Dec 9, 2022
@cpcloud cpcloud requested a review from kszucs December 9, 2022 11:38
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Test Results

       41 files         41 suites   1h 35m 25s ⏱️
11 916 tests   9 044 ✔️   2 829 💤 43
42 499 runs  32 130 ✔️ 10 283 💤 86

For more details on these failures, see this check.

Results for commit ae83ca6.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #4985 (ae83ca6) into master (8b711e9) will decrease coverage by 11.53%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4985       +/-   ##
===========================================
- Coverage   92.84%   81.30%   -11.54%     
===========================================
  Files         206      206               
  Lines       23119    23119               
  Branches     3236     3236               
===========================================
- Hits        21464    18798     -2666     
- Misses       1216     3814     +2598     
- Partials      439      507       +68     
Impacted Files Coverage Δ
ibis/backends/bigquery/version.py 0.00% <0.00%> (-100.00%) ⬇️
ibis/backends/bigquery/rewrites.py 0.00% <0.00%> (-100.00%) ⬇️
ibis/backends/bigquery/operations.py 0.00% <0.00%> (-100.00%) ⬇️
ibis/backends/bigquery/udf/rewrite.py 0.00% <0.00%> (-100.00%) ⬇️
ibis/backends/clickhouse/datatypes.py 0.00% <0.00%> (-100.00%) ⬇️
ibis/backends/clickhouse/identifiers.py 0.00% <0.00%> (-100.00%) ⬇️
ibis/backends/bigquery/registry.py 0.00% <0.00%> (-97.32%) ⬇️
ibis/backends/bigquery/compiler.py 0.00% <0.00%> (-96.97%) ⬇️
ibis/backends/bigquery/datatypes.py 0.00% <0.00%> (-96.43%) ⬇️
ibis/backends/bigquery/udf/__init__.py 0.00% <0.00%> (-96.30%) ⬇️
... and 58 more

@cpcloud
Copy link
Member Author

cpcloud commented Dec 9, 2022

Well, maybe this was a bit too aggressive. syrupy apparently doesn't work with pytest-xdist and getting it to do so seems fraught at the moment.

@cpcloud cpcloud closed this Dec 9, 2022
@cpcloud cpcloud deleted the syrupy branch December 9, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs related to dependencies developer-tools Tools related to ibis development tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguish M-TIMESTAMP and m-TIMESTAMP
1 participant