chore: remove unused _create_table_or_temp_view_from_csv() #5704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A grep for this shows it only appears in these two places, and it's a private method so it shouldn't be used by anyone.
|
I ran into this in #5702 when I accidentally modified this test, so then I started investigating. |
cpcloud
approved these changes
Mar 8, 2023
|
That failing test looks unrelated? |
|
It does. Lemme kick it and see if it's reproducible. |
NickCrews
added a commit
to NickCrews/ibis
that referenced
this pull request
Mar 8, 2023
cpcloud
pushed a commit
that referenced
this pull request
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A grep for this shows it only appears in these
two places, and it's a private method so
it shouldn't be used by anyone.