-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Create Ibis for dplyr users document #6050
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thanks for having a go-through @cpcloud. I resolved all but two of your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together @amoeba and @fmichonneau!
I flagged a few typos and some small language nits, but nothing major.
One gotcha with Ibis that might trip up users coming from dplyr is when a column name collides with the name of a method of the Ibis table object. For example if you have a column named |
Thanks for the review @gforsyth, I took all of your suggestions as-is and left one question for you about NULL ordering. Thanks also for the review @ianmcook! I took all of your suggestions and left one conversation unresolved. Your point about name collisions on columns is a good one. It didn't feel high-level enough to cover at the top so I put it as a note in the |
cff2c13
to
b3d82e5
Compare
Thanks all. I've rebased the branch off main and I think all feedback has been incorporated without issue. This is ready for a final review if anyone wants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amoeba and @fmichonneau !
This looks great and we should
Can you squash the commits down and format the message using conventional commit style?
Maybe something like docs(intro): create Ibis for dplyr users document
33c7a6d
to
0a96ee4
Compare
Co-authored-by: François Michonneau <francois.michonneau@gmail.com> Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com> Co-authored-by: Ian Cook <ianmcook@gmail.com> Co-authored-by: Gil Forsyth <gil@forsyth.dev>
0a96ee4
to
d3f8ca0
Compare
Fixed up the pre-commit issue! Merging! |
Addresses #5922.
@fmichonneau and I paired up on #5922 during the recent Ibis doc-a-thon. To keep the work in scope for the doc-a-thon, we decided to start small and base the content on https://dplyr.tidyverse.org/articles/dplyr.html. @fmichonneau brought that content in and developed Ibis equivalents for each bit. I then extended that by adding a section at the top highlighting major differences and also added in joins and pivoting to make it more comprehensive.
@fmichonneau could you take a look, especially at the content I added?
After that, I think it'd be good to get @ianmcook to review and also a core Ibis dev.
Specific bits of feedback I'm interested in are: